[E-2] 17-LangGraph / 01-Core-Features / 12-Conversation-Summaries-with-LangGraph #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppakyeah
previously approved these changes
Jan 22, 2025
There was a problem hiding this comment.
🖥️ OS: Mac
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: {Write freely, 한국어 기술 가능}
코드 정상 동작하며 내용도 빠진 것 없이 잘 작성된 것으로 보입니다. 고생하셨습니다!
architectyou
requested changes
Jan 24, 2025
There was a problem hiding this comment.
🖥️ OS: mac
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: 레퍼런스 링크페이지 재확인이 필요할 것 같습니다! 첫번째 링크는 page not found가 뜹니다..!
|
레퍼런스 링크페이지에 오류가 있었습니다. 이 부분 수정하여 커밋 올려놨습니다! 감사합니다! |
architectyou
previously approved these changes
Jan 27, 2025
| "\n", | ||
| "### References\n", | ||
| "\n", | ||
| "- [LangChain ChatOpenAI API reference](https://python.langchain.com/docs/modules/model_io/models/chat_openai) \n", |
There was a problem hiding this comment.
안녕하세요! 일전에[ 관련 문제를 지적해주셔서 수정 후 커밋해서 반영을 완료하였는데요 혹시 반영된 내용이 안보이실까요?
| "### References\n", | ||
| "\n", | ||
| "- [LangChain ChatOpenAI API reference](https://python.langchain.com/docs/modules/model_io/models/chat_openai) \n", | ||
| "- [LangSmith documentation](https://smith.langchain.com) \n", |
There was a problem hiding this comment.
랭스미스 docs가 아니라 메인으로 연결되어 https://docs.smith.langchain.com/ 로 수정하셔야 할 것 같습니다!
| "\n", | ||
| "- [LangChain ChatOpenAI API reference](https://python.langchain.com/docs/modules/model_io/models/chat_openai) \n", | ||
| "- [LangSmith documentation](https://smith.langchain.com) \n", | ||
| "- [LangChain Core - Memory and Conversational AI](https://github.com/hwchase17/langchain) \n", |
There was a problem hiding this comment.
요것도 해당레퍼런스 링크가 맞나요..? 확인 부탁드립니다..!
ppakyeah
previously approved these changes
Jan 31, 2025
|
@chaeyoonyunakim 님 해당 PR 검토 요청 드립니다~ :) |
75ecd28
chaeyoonyunakim
previously approved these changes
Feb 1, 2025
There was a problem hiding this comment.
안녕하세요 @JunseongKim1104 님, 번역/검수 확인 후 수정 커밋 변경있었습니다.
- 소문자 시작 헤딩 대문자로 변경
- 헤딩 아래로 설명 들어갈 때 한 줄 띄우기. 동일 마크다운 내 새로운 문단 시작 시에도 한줄 띄우기 (엔터 두번)
- 그 외 사소한 문법 (위 2가지 수정이 없었다면 커밋하지 않았을 것 같은) 수정 있었습니다.
기존 리뷰어 분들 Approval 재요청 드리겠습니다. 감사합니다
chaeyoonyunakim
approved these changes
Feb 1, 2025
|
@chaeyoonyunakim 님 꼼꼼한 검토 감사드립니다. 감사합니다. |
ppakyeah
approved these changes
Feb 2, 2025
architectyou
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 중간에 directory가 추가되어서 해당 부분을 pull 하느라 commit 이 몇 개 더 생겼습니다.
검토 부탁드립니다!
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N