Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[E-3] 17-LangGraph/02-Structures/LangGraph-Add-Query-Rewrite #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 4, 2025
Merged

[E-3] 17-LangGraph/02-Structures/LangGraph-Add-Query-Rewrite #488

merged 6 commits into from
Feb 4, 2025

Conversation

sunworl
Copy link
Contributor

@sunworl sunworl commented Jan 21, 2025

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynbΒ #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

πŸ–₯️ OS: Win/Mac/Linux   
βœ… Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, ν•œκ΅­μ–΄ 기술 κ°€λŠ₯}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@sunworl sunworl self-assigned this Jan 21, 2025
@sunworl sunworl changed the title [E-3] 17-LangGraph/02-Structures-LangGraph-Add-Query-Rewrite [E-3] 17-LangGraph/02-Structures/LangGraph-Add-Query-Rewrite Jan 21, 2025
@chaeyoonyunakim chaeyoonyunakim added docs tutorial proofreading λ²ˆμ—­/κ²€μˆ˜νŒ€ μ œμ•ˆμ‚¬ν•­ 반영 labels Jan 21, 2025
samdaseuss
samdaseuss requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@samdaseuss samdaseuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ–₯️ OS: Win/Mac/Linux
βœ… Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, ν•œκ΅­μ–΄ 기술 κ°€λŠ₯}

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€ :)

그런데 rag ν΄λ”μ˜ νŒŒμΌμ€ 좩돌 λ•Œλ¬Έμ— μ˜¬λ¦¬μ§€ μ•ŠλŠ”κ±Έλ‘œ μ•Œκ³  μžˆλŠ”λ° ν˜Ήμ‹œ λͺ¨λ₯΄λ‹ˆ 일단 보λ₯˜ν•΄λ†“κ² μŠ΅λ‹ˆλ‹€!

sunworl and others added 3 commits January 24, 2025 12:56
@sunworl
Merge branch 'LangChain-OpenTutorial:main' into main
a7f57a6
@sunworl
[E-3] 17-LangGraph/02-Structures/LangGraph-Add-Query-Rewrite
592985b 
1. rag 폴더 μ‚­μ œ
2. langchain_opentutorial 라이브러리 ν™œμš© (일뢀 rag 파일 λŒ€μ²΄)
@sunworl
[E-3] 17-LangGraph/02-Structures/LangGraph-Add-Query-Rewrite
aa05efe 
μ˜€νƒ€ μˆ˜μ •
@sunworl
Copy link
Contributor Author

sunworl commented Jan 24, 2025

πŸ–₯️ OS: Win/Mac/Linux βœ… Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, ν•œκ΅­μ–΄ 기술 κ°€λŠ₯}

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€ :)

그런데 rag ν΄λ”μ˜ νŒŒμΌμ€ 좩돌 λ•Œλ¬Έμ— μ˜¬λ¦¬μ§€ μ•ŠλŠ”κ±Έλ‘œ μ•Œκ³  μžˆλŠ”λ° ν˜Ήμ‹œ λͺ¨λ₯΄λ‹ˆ 일단 보λ₯˜ν•΄λ†“κ² μŠ΅λ‹ˆλ‹€!

rag폴더 μ‚­μ œν•˜μ—¬ 좩돌 μœ„ν—˜ ν•΄κ²°ν–ˆμŠ΅λ‹ˆλ‹€.

@sunworl sunworl requested a review from samdaseuss January 24, 2025 06:07
MoonHeesun
MoonHeesun approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@MoonHeesun MoonHeesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ–₯️ OS: Win
βœ… Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments:

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€! λͺ¨λ“  μ½”λ“œκ°€ 잘 μ‹€ν–‰λ˜λŠ” κ²ƒκΉŒμ§€ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€ :)

MoonHeesun
MoonHeesun previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@MoonHeesun MoonHeesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve ν•œ μƒνƒœμ§€λ§Œ.. λ’€λŠ¦κ²Œ ν•œ 가지 더 comment λ‚¨κΉλ‹ˆλ‹€..!

17-LangGraph/02-Structures/05-LangGraph-Add-Query-Rewrite.ipynb Outdated
"# LangGraph-Add-Query-Rewrite\n",
"\n",
"- Author: [Sunworl Kim](https://github.com/sunworl)\n",
"- Design:\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κΈ°μ—¬μž ν”„λ‘œν•„ μž‘μ„± κ°€μ΄λ“œμ— 따라 design ν”„λ‘œν•„μ€ μΆ”κ°€ν•΄μ£Όμ…”μ•Ό ν•  것 κ°™μŠ΅λ‹ˆλ‹€!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ†“μΉ˜κ³  μžˆμ—ˆλŠ”λ°, μ•Œλ €μ£Όμ…”μ„œ κ°μ‚¬ν•©λ‹ˆλ‹€.
μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

@sunworl
[E-3] 17-LangGraph/02-Structures/LangGraph-Add-Query-Rewrite
3a2816c 
κΈ°μ—¬μž ν”„λ‘œν•„ μž‘μ„± κ°€μ΄λ“œμ— 따라 design ν”„λ‘œν•„ μΆ”κ°€
@sunworl sunworl requested a review from MoonHeesun January 24, 2025 14:50
MoonHeesun
MoonHeesun previously approved these changes Jan 24, 2025
View reviewed changes
@sunworl
Update 05-LangGraph-Add-Query-Rewrite.ipynb
34a627a 
"TAVILY_API_KEY" λΆˆν•„μš”ν•˜μ—¬ μ‚­μ œ
chaeyoonyunakim
chaeyoonyunakim approved these changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@chaeyoonyunakim chaeyoonyunakim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•ˆλ…•ν•˜μ„Έμš” @sunworl λ‹˜, peer-reviewκ°€ μ§„ν–‰μ€‘μž…λ‹ˆλ‹€λ§Œ μ‹œκ°„μ„ 쀄이기 μœ„ν•΄ λ²ˆμ—­/κ²€μˆ˜ 확인 같이 μ§„ν–‰ν•˜μ˜€μŠ΅λ‹ˆλ‹€. 기술적인 λ‚΄μš©μ΄ 잘 ν‘œν˜„λ˜μ§€ μ•Šμ€ 뢀뢄듀이 μžˆλŠ” λ“― ν•˜μ—¬ λͺ‡ 가지 λ¬Έμž₯을 μˆ˜μ • μ œμ•ˆ λ“œλ¦¬λ‹ˆ 확인 ν›„ ν•„μš”ν•˜μ‹œλ©΄ 반영 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€. κ°μ‚¬ν•©λ‹ˆλ‹€.

samdaseuss
samdaseuss approved these changes Feb 2, 2025
View reviewed changes
Copy link
Contributor

@samdaseuss samdaseuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ–₯️ OS: Win/Mac/Linux
βœ… Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, ν•œκ΅­μ–΄ 기술 κ°€λŠ₯}
    μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€ :)

@sunworl
Copy link
Contributor Author

sunworl commented Feb 3, 2025

μ•ˆλ…•ν•˜μ„Έμš” @sunworl λ‹˜, peer-reviewκ°€ μ§„ν–‰μ€‘μž…λ‹ˆλ‹€λ§Œ μ‹œκ°„μ„ 쀄이기 μœ„ν•΄ λ²ˆμ—­/κ²€μˆ˜ 확인 같이 μ§„ν–‰ν•˜μ˜€μŠ΅λ‹ˆλ‹€. 기술적인 λ‚΄μš©μ΄ 잘 ν‘œν˜„λ˜μ§€ μ•Šμ€ 뢀뢄듀이 μžˆλŠ” λ“― ν•˜μ—¬ λͺ‡ 가지 λ¬Έμž₯을 μˆ˜μ • μ œμ•ˆ λ“œλ¦¬λ‹ˆ 확인 ν›„ ν•„μš”ν•˜μ‹œλ©΄ 반영 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€. κ°μ‚¬ν•©λ‹ˆλ‹€.

κ²€ν† ν•΄μ£Όμ‹  λ‚΄μš© ν™•μΈν•˜μ˜€μŠ΅λ‹ˆλ‹€.
ν•΄λ‹Ή PR이 μ‹œκ°„μ΄ μ’€ μ§€μ—°λœ κ΄€κ³„λ‘œ....λ¨Όμ € merge 후에 λ²ˆμ—­/κ²€μˆ˜ λΆ€λΆ„ μˆ˜μ •ν•˜μ—¬ λ‹€μ‹œ PR ν•˜λŠ”κ²Œ 쒋을 λ“― ν•©λ‹ˆλ‹€.

@teddylee777 teddylee777 merged commit 7359e42 into LangChain-OpenTutorial:main Feb 4, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeyoonyunakim chaeyoonyunakim chaeyoonyunakim approved these changes

@samdaseuss samdaseuss samdaseuss approved these changes

@MoonHeesun MoonHeesun MoonHeesun approved these changes

Assignees

@sunworl sunworl

Labels
docs tutorial proofreading λ²ˆμ—­/κ²€μˆ˜νŒ€ μ œμ•ˆμ‚¬ν•­ 반영
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sunworl @chaeyoonyunakim @samdaseuss @MoonHeesun @teddylee777