[E-4] 17-LangGraph / 03-Use Cases / 02-LangGraph-Prompt-Generation #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Directory 설정이 잘못된것 같습니다. 다시 PR 생성 하도록 하겠습니다. |
|
폴더 이름 수정이 되었습니다. 혼란을 드려서 죄송 합니다. 감사 합니다. |
choincnp
requested changes
Jan 22, 2025
There was a problem hiding this comment.
안녕하세요 @gyjong 님, PR시 Review template는 나중에 리뷰할때 작성하는 부분이라, template말고 위의 부분을 작성해주세요!
🖥️ OS: Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments:
작성하시느라 너무 고생 많으셨어요. 다만 고쳐야 할 부분이 2가지 보입니다.
- .ipynb파일의 폴더는 rag안이 아니라 Use-Cases 바로 아래에 위치해야 해요!
- Reference 부분이 없다면, 지워 주세요!
|
choincnp님, 리뷰 넘 감사 드립니다. |
cjLee-cmd
reviewed
Jan 23, 2025
There was a problem hiding this comment.
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments:
고생 하셨습니다...
- "LANGCHAIN_PROJECT": "CH17-LangGraph-Use-Cases" <= 전체 폴더 경로를 다 넣어야 하지 않을까요...?^^
- 그림 사이즈 검토 바랍니다.(다른 팀에서 취합해서 해 주는지 모르겠습니다만, 일단 코멘트 드립니다.)
|
cjLee-cmd님 의견 감사 합니다. |
|
cjLee-cmd님 리뷰/승인 감사 합니다. |
|
choincnp님 리뷰 감사 합니다. |
chaeyoonyunakim
approved these changes
Jan 24, 2025
90e43a0
into
LangChain-OpenTutorial:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이미지 디자인 결과 반영하고, SF 출장 여정 작성 Prompt 시나리오 적용해 보았습니다.
검토 부탁 드립니다. 감사 합니다.
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N