Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[E-1] 17-LangGraph / 01-Core-Features / 01-LangGraph-Introduction #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2025
Merged

[E-1] 17-LangGraph / 01-Core-Features / 01-LangGraph-Introduction #499

merged 1 commit into from
Jan 26, 2025

Conversation

ThePurpleCollar
Copy link
Contributor

Initial

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@ThePurpleCollar ThePurpleCollar added the docs tutorial label Jan 22, 2025
@ThePurpleCollar ThePurpleCollar self-assigned this Jan 22, 2025
@forwardyoung
Copy link
Contributor

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}
    에러 발생하는 부분도 없고, 인트로에 TypedDict에 대한 설명부터 엄청 꼼꼼하게 잘 작성해주셨네요! 수고하셨습니다.
    튜토리얼의 좋은 예시 같습니다:)

@chaeyoonyunakim chaeyoonyunakim self-requested a review January 22, 2025 06:55
@chaeyoonyunakim chaeyoonyunakim added the proofreading 번역/검수팀 제안사항 반영 label Jan 22, 2025
hong-seongmin
hong-seongmin approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@hong-seongmin hong-seongmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: 큰 문제점을 확인하지 못하였습니다. 수고하셨습니다.

@jeong-wooseok jeong-wooseok changed the title [E-1] 17-LangGraph / 01-LangGraph-Introduction [E-1] 17-LangGraph / 01-Core-Features / 01-LangGraph-Introduction Jan 22, 2025
@jeong-wooseok
Copy link
Contributor

🖥️ OS: Win/Mac/Linux
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • [X ] Image: Image filenames follow guidelines.
  • [ X] Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • [ X] Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}
  • 고생 많으셨습니다.

chaeyoonyunakim
chaeyoonyunakim reviewed Jan 24, 2025
View reviewed changes
17-LangGraph/01-Core-Features/01-LangGraph-Introduction.ipynb
"metadata": {},
"outputs": [],
"source": [
"from typing import Annotated\\\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import Annotated\ 재확인 요청드립니다

chaeyoonyunakim
chaeyoonyunakim approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@chaeyoonyunakim chaeyoonyunakim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요, 4주차 번역/검수 확인입니다. 선택사항으로 만약, 몇 가지 문장 수정이 가능하다면 제안드립니다. 판단에 따라 반영하지 않으셔도 괜찮습니다. 감사합니다

@teddylee777 teddylee777 merged commit 7757421 into LangChain-OpenTutorial:main Jan 26, 2025
1 of 2 checks passed
@teddylee777
Copy link
Contributor

@chaeyoonyunakim 님 제안 감사합니다.
우선 approve 요건 충족하여 merge 한 상황이고요. 제안 내용을 추후 반영하여 원 저자(author) 님께서 제안을 수용하여 개선해 주시는 경우 PR 새롭게 오픈해 주시면 감사드리겠습니다.
모두 고생하셨습니다. 감사합니다!

@ThePurpleCollar
Copy link
Contributor Author

@chaeyoonyunakim @teddylee777 제안해 주신 내용 확인했습니다. 검토 후 반영하여 PR 요청드리겠습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeyoonyunakim chaeyoonyunakim chaeyoonyunakim approved these changes

@hong-seongmin hong-seongmin hong-seongmin approved these changes

@forwardyoung forwardyoung forwardyoung approved these changes

@jeong-wooseok jeong-wooseok Awaiting requested review from jeong-wooseok

Assignees

@ThePurpleCollar ThePurpleCollar

Labels
docs tutorial proofreading 번역/검수팀 제안사항 반영
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ThePurpleCollar @forwardyoung @jeong-wooseok @teddylee777 @chaeyoonyunakim @hong-seongmin