Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sungchul2
Copy link
Contributor

@sungchul2 sungchul2 commented Jan 22, 2025

TODO

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@sungchul2 sungchul2 self-assigned this Jan 22, 2025
@sungchul2 sungchul2 force-pushed the ch17-07-langgraph-03-use-cases-multi-agent-supervisor branch from 87a6def to a1a3417 Compare January 22, 2025 06:57
@chaeyoonyunakim chaeyoonyunakim self-requested a review January 22, 2025 06:58
@chaeyoonyunakim chaeyoonyunakim added docs tutorial proofreading 번역/검수팀 제안사항 반영 labels Jan 22, 2025
Copy link
Contributor

@choincnp choincnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Mac
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments:
    안녕하세요 @rlatjcj 님, 먼저 좋은 튜토리얼 만드시느라 너무 고생 많으셨습니다.
    다만 변경해야 할 점이 몇개 보이는데요,
  1. invoke_graph 부분은 langchain_opentutorial 패키지에서 임포트 부탁드릴게요. 현재 정상적으로 update된 state가 출력되지 않고 있습니다.
  2. tavily api를 받아 오는데 키를 입력하는 부분이 없어서, 환경 설정에서도 이 부분 추가를 해 주셔야 할 것 같아요.
  3. 처음 부분에서 designer 부분은 지우지 말고 공란으로 놔둬 주세요!

감사합니다 :) 제가 토요일 출국 일정이 있어서 금방 고쳐주시면, 금방 리뷰드리겠습니다.

- use `langchain_opentutorial` tools
- add `TAVILY_API_KEY` in Environment Setup
- add `Design` in the top
@sungchul2 sungchul2 force-pushed the ch17-07-langgraph-03-use-cases-multi-agent-supervisor branch from 81eb4ce to 3da2a32 Compare January 23, 2025 01:48
@sungchul2
Copy link
Contributor Author

sungchul2 commented Jan 23, 2025

🖥️ OS: Mac ✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments:
    안녕하세요 @rlatjcj 님, 먼저 좋은 튜토리얼 만드시느라 너무 고생 많으셨습니다.
    다만 변경해야 할 점이 몇개 보이는데요,
  1. invoke_graph 부분은 langchain_opentutorial 패키지에서 임포트 부탁드릴게요. 현재 정상적으로 update된 state가 출력되지 않고 있습니다.
  2. tavily api를 받아 오는데 키를 입력하는 부분이 없어서, 환경 설정에서도 이 부분 추가를 해 주셔야 할 것 같아요.
  3. 처음 부분에서 designer 부분은 지우지 말고 공란으로 놔둬 주세요!

감사합니다 :) 제가 토요일 출국 일정이 있어서 금방 고쳐주시면, 금방 리뷰드리겠습니다.

@choincnp 리뷰 감사합니다! 수정했습니다 3da2a32

Copy link
Contributor

@Normalist-K Normalist-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win/Mac/Linux
✅ Checklist

  • Template: Tutorials follows the required template.
  • [�x] Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}

수고 많으셨습니다. 코드 잘 돌아가네요!
몇가지 template 관련 수정해야할 부분만 수정해주시면 될 것 같습니다~

- add spaces before and after bold and backtick
- add a line below `References`
Copy link
Contributor

@choincnp choincnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다. :) @Normalist-K 님께서 너무 잘 짚어주신 것 같아요.

@chaeyoonyunakim chaeyoonyunakim removed the proofreading 번역/검수팀 제안사항 반영 label Jan 24, 2025
@teddylee777 teddylee777 merged commit 0110e4f into LangChain-OpenTutorial:main Jan 24, 2025
3 of 4 checks passed
@sungchul2 sungchul2 deleted the ch17-07-langgraph-03-use-cases-multi-agent-supervisor branch January 31, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants