Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[E-1] 10-Retriever / 10-Kiwi-BM25-Retriever #415 #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2025
Merged

[E-1] 10-Retriever / 10-Kiwi-BM25-Retriever #415 #509

merged 2 commits into from
Feb 1, 2025
+48 −114

Conversation

jeongkpa
Copy link
Contributor

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@ee-juni @BokyungisaGod 님 #415 커밋 내역들 모두 확인했고, 수정돼있는 부분은 유지하고 수정 안돼있는 typo 수정 후 리뷰 부탁드립니다.

@jeongkpa jeongkpa self-assigned this Jan 22, 2025
@jeongkpa jeongkpa added the proofreading 번역/검수팀 제안사항 반영 label Jan 22, 2025
@ee-juni
Copy link
Contributor

ee-juni commented Jan 22, 2025

죄송합니다, 정기님!
제가 수정된 커밋 링크를 잘못 첨부했었네요.
수정된 버젼의 참고용 커밋 링크 다시 한번 더 확인하셔서 변경사항 검토해주실 수 있으면 감사하겠습니다.

더불어, 먼저 올려주신 수정 사항에 BM25에 backtick 넣으신 건 빼셔도 됩니다!
BM25은 검색 알고리즘의 일종이고, 텍스트 상에 function이라 하는 건 코드 상의 function을 의미하지 않음으로 backtick 적용 대상이 아닙니다!

번거롭게 해드려서 죄송합니다 🙇

@BokyungisaGod
Copy link
Contributor

@jeongkpa 님 준의님 코멘트 확인 부탁드립니다:) 수정 후 멘션+코멘트 주시면 감사하겠습니다!!

@jeongkpa
Copy link
Contributor Author

@BokyungisaGod @ee-juni 수정했습니다! 코멘트 감사합니다!!

BokyungisaGod
BokyungisaGod approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@BokyungisaGod BokyungisaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다:)

ee-juni
ee-juni approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@ee-juni ee-juni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@teddylee777 teddylee777 merged commit 3512bb0 into LangChain-OpenTutorial:main Feb 1, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ee-juni ee-juni ee-juni approved these changes

@BokyungisaGod BokyungisaGod BokyungisaGod approved these changes

Assignees

@jeongkpa jeongkpa

Labels
proofreading 번역/검수팀 제안사항 반영
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeongkpa @ee-juni @BokyungisaGod @teddylee777