-
Notifications
You must be signed in to change notification settings - Fork 282
[E-1] 17-LangGraph / 01-Core-Features / 06-LangGraph-Human-in-the-loop #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🖥️ OS: Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments:
- ToC 중 오탈자 Environement Setup -> Environment Setup
- 질문 :
- Setup the Graph 중 tool 정의하고 bind 하는 부분에서 def
search_keyword
와 tools = [search_keyword] 사이에 news_tool = GoogleNews() 이거는 필요 없는 줄 아닌지 확인 부탁드립니다. - Graph 정의 중 Add the Node -> Add Nodes, Add the Edge -> Add Edges
@Hye-yoonJeong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정사항 반영과 코드 정상작동함을 확인하였습니다! 고생많으셨습니다! :)
오류 없이 깔끔하게 작성된 코드와 설명이 인정적이네요. 고생하셨습니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
번역/검수 확인했습니다. 잘 쓰여진 문장들이라 오히려 리뷰 시간이 더 오래 걸린 것 같습니다. 소제목 중 Setup the Graph
가 전후 제목 형식과 달라 통일하고자 몇 가지 대안을 제안드립니다: Setting up the Graph
혹은 Graph Setup
, Graph Configurations
, Graph initialization
등이 가능합니다. 제가 commit하여 approval과정을 다시 거칠 만큼 사안은 아니라 comment로 대신합니다. 감사합니다.
171a917
@chaeyoonyunakim @Hye-yoonJeong @ThePurpleCollar |
aafb7d5
into
LangChain-OpenTutorial:main
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N