Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

seofield
Copy link
Contributor

@seofield seofield commented Jan 22, 2025

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@seofield seofield requested review from suhyun0115 and jhboyo January 22, 2025 12:47
@suhyun0115
Copy link
Contributor

suhyun0115 commented Jan 22, 2025

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}
    고생하셨습니다! 덕분에 많이 배웠습니다!

@chaeyoonyunakim chaeyoonyunakim self-requested a review January 23, 2025 07:14
@chaeyoonyunakim chaeyoonyunakim added docs tutorial proofreading 번역/검수팀 제안사항 반영 labels Jan 23, 2025
jhboyo
jhboyo previously approved these changes Jan 23, 2025
Copy link
Contributor

@jhboyo jhboyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win/Mac/Linux
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: 코드 모두 정상 작동하고 특이사항 없습니다. 고생 많으셨습니다!

suhyun0115
suhyun0115 previously approved these changes Jan 25, 2025
@chaeyoonyunakim chaeyoonyunakim dismissed stale reviews from suhyun0115 and jhboyo via 9e48cc9 January 25, 2025 17:43
Copy link
Contributor

@chaeyoonyunakim chaeyoonyunakim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 @seofield 님, 번역/검수 확인 후 수정 커밋 변경있었습니다.

  1. 개요 단락에 배치된 그림을 설명 다음에 오도록 변경
  2. (수평선을 긋는 dash는 References 뒤로만 적용 기준에 따라) line143 '---' 삭제
  3. block quote >로 들어간 "superstep" 설명을 해당 본문 아래로 재배치
  4. 그외 몇 가지 사소한 수정 (앞선 3가지 수정이 없었다면 하지 않았을 것 같은) 내용들이 있습니다: B and CNode B and Note C로 수정 등

기존 리뷰어 분들 Approval 재요청 드리겠습니다. 감사합니다

@teddylee777 teddylee777 merged commit d7b31a8 into LangChain-OpenTutorial:main Jan 26, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs tutorial proofreading 번역/검수팀 제안사항 반영
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants