-
Notifications
You must be signed in to change notification settings - Fork 282
[E-3] 17-LangGraph / 02-Structures / 02-LangGraph-Naive-RAG #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[E-3] 17-LangGraph / 02-Structures / 02-LangGraph-Naive-RAG #516
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rag.pdf 가 없다고 나옵니다!!
@jeongkpa 안녕하세요, 해당 부분은 전체적으로 rag, assets 폴더에 파일 집어넣을 예정이라, 원본의 pdf.rag 넣고 테스트해주시면 감사하겠습니다. 충돌날까봐 일부러 /rag/pdf.py를 넣지 않았습니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🖥️ OS: Win
✅ Checklist
Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}
영준님 고생 많으셨습니다.
전체적으로 오류없이 수행되었습니다.
다만, 몇가지 수정 사항만 요청드립니다.
Table of Contents의 작동은 문제 없었으나 표현의 일부 수정이 필요하고,
공통적으로 활용하기로 한 파일 수정이 필요해 보입니다.
감사합니다.
@sunworl 수정했습니다 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고 많으셨습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🖥️ OS: Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
- Image: Image filenames follow guidelines.
- Imports : All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
수고하셨습니다!!
@teddylee777 테디님 머지 부탁드립니다! |
fba77c1
into
LangChain-OpenTutorial:main
안녕하세요, 열심히 만들었습니다 :) 감사합니다. 좋은 리뷰 부탁드립니다.
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N