Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

choincnp
Copy link
Contributor

안녕하세요, 열심히 만들었습니다 :) 감사합니다. 좋은 리뷰 부탁드립니다.

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@choincnp choincnp requested review from sunworl and jeongkpa January 22, 2025 13:14
@chaeyoonyunakim chaeyoonyunakim self-requested a review January 23, 2025 07:15
@chaeyoonyunakim chaeyoonyunakim added docs tutorial proofreading 번역/검수팀 제안사항 반영 labels Jan 23, 2025
@jeongkpa
Copy link
Contributor

image
@choincnp 안녕하세요..!!

rag.pdf 가 없다고 나옵니다..! 확인 바랍니다!!
image

Copy link
Contributor

@jeongkpa jeongkpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rag.pdf 가 없다고 나옵니다!!

@choincnp
Copy link
Contributor Author

@jeongkpa 안녕하세요, 해당 부분은 전체적으로 rag, assets 폴더에 파일 집어넣을 예정이라, 원본의 pdf.rag 넣고 테스트해주시면 감사하겠습니다. 충돌날까봐 일부러 /rag/pdf.py를 넣지 않았습니다.

Copy link
Contributor

@sunworl sunworl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}
영준님 고생 많으셨습니다.
전체적으로 오류없이 수행되었습니다.

다만, 몇가지 수정 사항만 요청드립니다.
Table of Contents의 작동은 문제 없었으나 표현의 일부 수정이 필요하고,
공통적으로 활용하기로 한 파일 수정이 필요해 보입니다.
감사합니다.

@choincnp
Copy link
Contributor Author

@jeongkpa @sunworl 두분 다 너무너무 좋은 피드백 감사합니다. 수정사항 고쳤습니다!

@sunworl
Copy link
Contributor

sunworl commented Jan 24, 2025

@jeongkpa @sunworl 두분 다 너무너무 좋은 피드백 감사합니다. 수정사항 고쳤습니다!

하나만 더 요청드릴게요.
기여자 프로필 작성 가이드에 따라 design 프로필이 추가되어야 합니다.

확인되는데로 바로 승인하겠습니다.

@choincnp
Copy link
Contributor Author

@sunworl 수정했습니다 :)

@chaeyoonyunakim chaeyoonyunakim removed the proofreading 번역/검수팀 제안사항 반영 label Jan 24, 2025
Copy link
Contributor

@sunworl sunworl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다.

Copy link
Contributor

@jeongkpa jeongkpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports : All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
    수고하셨습니다!!

@jeongkpa
Copy link
Contributor

@teddylee777 테디님 머지 부탁드립니다!

@teddylee777 teddylee777 merged commit fba77c1 into LangChain-OpenTutorial:main Jan 26, 2025
1 of 2 checks passed
@choincnp choincnp deleted the tutorial-LangGraph-02 branch February 20, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants