Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[N-3] 17-LangGraph / 17-LongTermMemoryAgent #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 15, 2025
Merged

[N-3] 17-LangGraph / 17-LongTermMemoryAgent #521

merged 5 commits into from
Feb 15, 2025

Conversation

acho98
Copy link
Contributor

@acho98 acho98 commented Jan 22, 2025

[Title] LongTermMemoryAgent
[Version] draft
[Language] ENG
[Packages] langchain_openai, langgraph, langchain, langchain_community, faiss

Added draft notebook

@acho98
[N-3] 17-LangGraph / 17-LongTermMemoryAgent
9f8ec08 
[Title] LongTermMemoryAgent
[Version] draft
[Language] ENG
[Packages] langchain_openai, langgraph, langchain, langchain_community, faiss

Added draft notebook
@acho98 acho98 requested review from brian604 and BaBetterB January 22, 2025 14:07
@BaBetterB
Copy link
Contributor

🖥️ OS: Win
✅ Checklist

  • [O] Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}

고생많으십니다. 아직 작업 중이신것으로 판단됩니다.

  1. 파일 경로 검토 부탁드립니다. : 17-LangGraph\01-Core-Features 아래에 위치하고 있는것같습니다.
  2. Table of Contents : 오타 수정과 링크 연결 확인 부탁드립니다.

brian604
brian604 reviewed Jan 24, 2025
View reviewed changes
17-LangGraph/01-Core-Features/17-LongTermMemoryAgent.ipynb
"- Peer Review: \n",
"- This is a part of [LangChain Open Tutorial](https://github.com/LangChain-OpenTutorial/LangChain-OpenTutorial)\n",
"\n",
"[![Open in Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/LangChain-OpenTutorial/LangChain-OpenTutorial/blob/main/08-EMBEDDING/02-CacheBackedEmbeddings.ipynb) [![Open in LangChain Academy](https://cdn.prod.website-files.com/65b8cd72835ceeacd4449a53/66e9eba12c7b7688aa3dbb5e_LCA-badge-green.svg)](https://academy.langchain.com/courses/take/intro-to-langgraph/lessons/58239937-lesson-2-sub-graphs)\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix Colab link.

brian604
brian604 reviewed Jan 24, 2025
View reviewed changes
17-LangGraph/01-Core-Features/17-LongTermMemoryAgent.ipynb
"\n",
"- Author: [byoon](https://github.com/acho98)\n",
"- Design: []()\n",
"- Peer Review: \n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brian604

@brian604
Copy link
Contributor

brian604 commented Jan 24, 2025 •
edited
Loading

🖥️ OS: Github (checkout was not possible)
✅ Checklist

Template: Tutorials follows the required template.

  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • [ ]Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.

@BaBetterB 님과 의견 동일합니다.
Context가 잘 유지되었으면 좋겠습니다.

@acho98 acho98 requested a review from brian604 February 3, 2025 08:47
@acho98
Copy link
Contributor Author

acho98 commented Feb 3, 2025 •
edited
Loading

완성 코드 커밋하였습니다.
@BaBetterB 님 @brian604 님
리뷰 부탁드립니다.

감사합니다.

BaBetterB
BaBetterB reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@BaBetterB BaBetterB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win
✅ Checklist

[O] Template: Tutorials follows the required template.
[O] Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
[O] Image: Image filenames follow guidelines.
[O] Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
[O] Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}

정말 고생하셨습니다.
모든 코드가 정상작동하고 구성 내용과 주석이 잘되어있어 많이 배웠습니다.
상세한 프롬프트와 Knowledge Triple 등의 설명 및 그래프 이미지를 통해
튜토리얼의 학습자가 잘 활용할수 있을듯합니다.

BaBetterB
BaBetterB previously approved these changes Feb 4, 2025
View reviewed changes
@krkrong krkrong requested a review from changwonjeon February 11, 2025 23:53
@acho98 acho98 removed the request for review from brian604 February 11, 2025 23:55
@teddylee777 teddylee777 requested review from BokyungisaGod and removed request for BokyungisaGod February 13, 2025 13:40
changwonjeon
changwonjeon reviewed Feb 14, 2025
View reviewed changes
Copy link
Contributor

@changwonjeon changwonjeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review Checklist]

  • Review OS: Windows

  • Template Rule 준수 여부: 이상없음

  • Table of Contents 링크 확인: 이상없음. 다만 소문자 표기만 확인 부탁드립니다.

  • 이미지 파일명 검토: 이상없음

  • 최신 import 방식 사용 여부: 이상없음.
    -> 다만 matplotlib, networkx 패키지 확인 부탁드립니다.

  • 코드 동작 확인: 이상없음. 정상작동합니다!

  • 제출 파일 확인: 이상없음

  • 기타 의견:
    리뷰어팀 전창원입니다.
    윈도우11 환경에서 실행하였으며,
    코드는 정상적으로 이상없이 작동하였습니다.
    초기화 루틴 등을 포함하여 꼼꼼하게 가이드 코드 작성해주셔서
    보시는 분들에게도 큰 도움이 될 듯 합니다.

다만, 2개 패키지(matplotlib, networkx)가 추가 설치가 필요했습니다.
확인 부탁드립니다.
또한, TOC 작성시 소문자로 처리하는 부분도 확인 부탁드립니다.

고생 많으셨습니다.
감사합니다.

@acho98
Copy link
Contributor Author

acho98 commented Feb 14, 2025

@changwonjeon 님, @BaBetterB 님
리뷰 부탁드립니다.

감사합니다

@BaBetterB
Copy link
Contributor

🖥️ OS: Win
✅ Checklist

[O] Template: Tutorials follows the required template.
[O] Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
[O] Image: Image filenames follow guidelines.
[O] Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
[O] Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}

고생하셨습니다.
matplotlib, networkx 의견이 있어 추가했고 수정하신뒤에도 모든 코드가 정상 작동합니다.

changwonjeon
changwonjeon approved these changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@changwonjeon changwonjeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review Checklist]

  • Review OS: Windows

  • Template Rule 준수 여부: 이상없음

  • Table of Contents 링크 확인: 이상없음.

  • 이미지 파일명 검토: 이상없음

  • 최신 import 방식 사용 여부: 이상없음.

  • 코드 동작 확인: 이상없음. 정상작동합니다!

  • 제출 파일 확인: 이상없음

  • 기타 의견:
    리뷰어팀 전창원입니다.
    윈도우11 환경에서 실행하였으며,
    코드는 정상적으로 이상없이 작동하였습니다.
    이전 리뷰에서 제안드린 내용에 대한 변경점도 확인하였습니다.
    고생 많으셨습니다.
    감사합니다.

@teddylee777 teddylee777 merged commit 432ba19 into LangChain-OpenTutorial:main Feb 15, 2025
1 of 2 checks passed
@acho98 acho98 linked an issue Feb 17, 2025 that may be closed by this pull request
Proofread: 17 - LangGraph / 17 - LongTermMemoryAgent #697
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian604 brian604 brian604 left review comments

@changwonjeon changwonjeon changwonjeon approved these changes

@BaBetterB BaBetterB BaBetterB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proofread: 17 - LangGraph / 17 - LongTermMemoryAgent
5 participants
@acho98 @BaBetterB @brian604 @changwonjeon @teddylee777