[N-2] 09-VectorStore / 06-Elasticsearch #525

namyoungkim · 2025-01-22T14:23:30Z

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

XaviereKU · 2025-01-23T02:05:54Z

아직 정식은 아니라 코멘트만 남깁니다.

### 아래에 설명 달아주신 것들 그냥 설명하는 내용이라면 bullet point *, - 없이 그냥 줄글로 적어주시는게 통일성 측면에서 조금 더 좋지 않을까 하는 생각입니다!

namyoungkim · 2025-01-23T05:54:51Z

@XaviereKU 종호님 안녕하세요!
엑셀 시트에 작성된 양식을 말씀 주신걸까요?! 🙂 (어디를 수정할지 봐보려고 합니다!)

XaviereKU · 2025-01-23T06:54:20Z

@XaviereKU 종호님 안녕하세요! 엑셀 시트에 작성된 양식을 말씀 주신걸까요?! 🙂 (어디를 수정할지 봐보려고 합니다!)

아! 엑셀시트가 아니라 ipynb 파일에서 ### 헤딩 아래에 있는 내용들을 bullet point로 정리해 주셨는데
줄글로 적다가 주요 포인트만 bullet point로 적는 것이 통일성이 있을 것 같아 말씀드렸습니다!

namyoungkim · 2025-01-23T11:53:49Z

@XaviereKU 종호님 안녕하세요! 엑셀 시트에 작성된 양식을 말씀 주신걸까요?! 🙂 (어디를 수정할지 봐보려고 합니다!)

아! 엑셀시트가 아니라 ipynb 파일에서 ### 헤딩 아래에 있는 내용들을 bullet point로 정리해 주셨는데 줄글로 적다가 주요 포인트만 bullet point로 적는 것이 통일성이 있을 것 같아 말씀드렸습니다!

아하! 이해했습니다~
이번에 인터페이스 통합한 후에 ipynb 파일 수정도 해보겠습니다~

pupba

🖥️ OS: Win
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments:
작업하시느라 고생하셨습니다! Window에서 이상 없이 동작 됩니다.
근대 금일 기준으로 Elasticsearch 키 만료되었네요 ㅠㅠ 다음 리뷰때 어떡할지는 PM님과 상의해보죠!

namyoungkim · 2025-02-06T04:05:06Z

@XaviereKU , @pupba
종호님, 광원님 안녕하세요.
제가 감기 몸살에 걸려서 늦게 커밋을 했습니다.
리뷰 부탁드려요 (_ _)

pupba

🖥️ OS: Win
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments:
고생하셨습니다! 이상 없습니다. 하지만 ES 프리티어가 14일 인데.... 앞으로 일정 생각하면 어떻게 해야할지 ㅠㅠ 모르겠네요...

XaviereKU

🖥️ OS: Win/Mac/Linux
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: 정상 작동 확인하였습니다. 수고하셨습니다!

namyoungkim · 2025-02-11T15:58:04Z

@XaviereKU , @pupba, @BokyungisaGod
종호님, 광원님, 보경님 안녕하세요.

다음 두 작업을 했습니다.

utils/elasticsearch.py 파일명 수정 (기존 utils/elasticsearch_interface.py)
utils/elasticsearch.py 에 맞춰 튜토리얼 재작성(elasticsearch.ipynb): 중복되는 내용 삭제

리뷰 부탁드립니다~!
감사합니다. 😊

XaviereKU

🖥️ OS: Win
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments:
기능들 모두 잘 작동하고 템플릿에도 문제 없는 것 같습니다.
다만 내용상에서 Search부분의 use_similarity가 False일 때 BM25인 것을 적어두는게 헷갈리지 않고 더 좋을 것 같습니다!

namyoungkim · 2025-02-14T01:56:37Z

docs: 기본 검색일 때, BM25 알고리즘으로 검색한다는 설명 추가

@XaviereKU 종호님 제안 감사합니다~!
위와 같이 기본 검색을 할 경우에는 BM25 알고리즘으로 검색한다는 설명 추가했습니다~!

한번 더 Approve 부탁드리겠습니다~!

pupba

🖥️ OS: Win
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}
작성하시느라 고생하셨습니다! Connection 부분을 추가하셨군요! Window에서 이상없이 동작합니다.

BokyungisaGod

수고하셨습니다:)

XaviereKU

🖥️ OS: Win
✅ Checklist

sohyunwriter · 2025-02-18T10:40:38Z

리뷰 Approve 최소 요건 충족해 머지 하겠습니다!

feat: add elasticsearch_interface.py file

cfabc15

namyoungkim requested review from XaviereKU and pupba January 22, 2025 14:24

pupba reviewed Jan 23, 2025

View reviewed changes

namyoungkim added 2 commits February 5, 2025 21:11

Merge branch 'LangChain-OpenTutorial:main' into main

97e788c

Update Elasticsearch Document manager and improve document handling.

1961c2a

pupba previously approved these changes Feb 6, 2025

View reviewed changes

XaviereKU previously approved these changes Feb 6, 2025

View reviewed changes

fix: elasticsearch.py 로 파일명 수정

1b6df07

namyoungkim dismissed stale reviews from XaviereKU and pupba via 1b6df07 February 11, 2025 14:25

namyoungkim added 3 commits February 11, 2025 23:26

fix: elasticsearch.py 로 파일명 수정

988fd68

fix: document_id 목록을 가져올 때, size를 설정할 수 있도록 변경

aba5b69

fix: utils/elasticsearch.py 에 맞춰 튜토리얼 재작성

609fa95

namyoungkim requested review from BokyungisaGod February 11, 2025 15:59

XaviereKU previously approved these changes Feb 12, 2025

View reviewed changes

docs: 기본 검색일 때, BM25 알고리즘으로 검색한다는 설명 추가

c8e1882

namyoungkim dismissed XaviereKU’s stale review via c8e1882 February 14, 2025 01:54

pupba approved these changes Feb 14, 2025

View reviewed changes

BokyungisaGod approved these changes Feb 15, 2025

View reviewed changes

XaviereKU approved these changes Feb 17, 2025

View reviewed changes

sohyunwriter merged commit 1812b01 into LangChain-OpenTutorial:main Feb 18, 2025
1 of 2 checks passed

[N-2] 09-VectorStore / 06-Elasticsearch #525

[N-2] 09-VectorStore / 06-Elasticsearch #525

Uh oh!

Conversation

namyoungkim commented Jan 22, 2025

Author Checklist

Review Template (Intial PR)

Uh oh!

XaviereKU commented Jan 23, 2025

Uh oh!

namyoungkim commented Jan 23, 2025

Uh oh!

XaviereKU commented Jan 23, 2025

Uh oh!

namyoungkim commented Jan 23, 2025

Uh oh!

pupba left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

namyoungkim commented Feb 6, 2025

Uh oh!

pupba left a comment

Choose a reason for hiding this comment

Uh oh!

XaviereKU left a comment

Choose a reason for hiding this comment

Uh oh!

namyoungkim commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XaviereKU left a comment

Choose a reason for hiding this comment

Uh oh!

namyoungkim commented Feb 14, 2025

Uh oh!

pupba left a comment

Choose a reason for hiding this comment

Uh oh!

BokyungisaGod left a comment

Choose a reason for hiding this comment

Uh oh!

XaviereKU left a comment

Choose a reason for hiding this comment

Uh oh!

sohyunwriter commented Feb 18, 2025

Uh oh!

Uh oh!

Uh oh!

pupba left a comment •

edited

Loading

namyoungkim commented Feb 11, 2025 •

edited

Loading