[N-1] 06-DocumentLoader / 13-LlamaParse #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Title] 06-DocumentLoader / 13-Llamaparse [Version] initial [Language] ENG [Packages] llama-index-core, llama-parse, llama-index-readers-file Included a tutorial on LlamaParse, covering basic usage, multimodal parsing, and custom instruction configurations.
[Title] 06-DocumentLoader / 13-Llamaparse [Version] revision [Language] ENG [Packages] llama-index-core, llama-parse, llama-index-readers-file Added a utility function to download and save a sample PDF file from a given URL to the `./data` directory in `DocumentLoader`
[Title] 06-DocumentLoader / 13-LlamaParse [Version] revision [Language] ENG [Packages] llama-index-core, llama-parse, llama-index-readers-file - changed file name from Llamaparse.ipynb to LlamaParse.ipynb - removed unused import
geminii01
previously approved these changes
Jan 2, 2025
There was a problem hiding this comment.
[Review]
- Review OS: Windows
- Template Rule 가이드를 준수 하였는가: YES
- Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?: YES
- 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?: N/A
- import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?: YES
- 모든 코드가 동작에 오류 없이 동작하는가? (만약, warning 발생시 코멘트에 적어주세요): YES
- 기타 의견: 고생 많으셨습니다!!
|
[Review]
아래처럼 해보니 출력 되긴 합니다. 기타 의견: 고생 많으셨습니다!! |
- 한번씩 LlamaParse 동작에 에러가 날때가 있습니다. - Attribute Error 시 위 셀을 다시 실행하라는 안내 문구를 추가했습니다.
|
@jhboyo 리뷰 감사합니다! 한번씩 LlamaParse 첫부분에서 오류 뜰 때가 있어서, 오류시 해당 코드 재실행해달라는 안내문구 추가했습니다. |
- remove print cell
|
해당 셀은 중요하지 않다고 판단되서 없앴습니다. 리뷰 감사드립니다! |
geminii01
approved these changes
Jan 3, 2025
|
[Review] Review OS: Mac 기타 의견: 늦은 리뷰 죄송합니다.. 다른 부분 동작 다 확인하였고 수고하셨습니다! |
leebeanbin
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Team] New Content Development Team 1
[Title] 06-DocumentLoader / 13-Llamaparse
[Version] initial
[Language] ENG
[Packages] llama-index-core, llama-parse, llama-index-readers-file
Included a tutorial on LlamaParse, covering basic usage, multimodal parsing, and custom instruction configurations.