[E-3] 17-LangGraph / 02-Structures / 06-LangGraph-Agentic-RAG #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choincnp
requested changes
Jan 22, 2025
There was a problem hiding this comment.
🖥️ OS: Mac
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments:
안녕하세요 @MoonHeesun 님, 먼저 튜토리얼 개발하시느라 고생 많으셨습니다!
다음과 같이 변경해주셔야 하는데요,
- 먼저 assets에 올라오는 이미지는 teddynote 이미지가 아닌, 새로 이미지파일 요청하셔서 받으셔야 합니다.
- !pip install -> %pip install입니다. 다음부터는 처음에 만드실 때 템플릿 잘 준수해서 이용하시면 좋겠습니다. 99-Template directory에 해당 파일 있습니다.
- rag dir 안에 있는 파일은 빼고 push날려주셨으면 좋겠어요. 충돌이 날 수 있어서요!
- data 안에 pdf는 Newwhitepaper_Agents2.pdf 파일로 통일해주시면 좋을 것 같아요. / 아니어도 상관없습니다.
나머지는 코드 execution 및 결과도 잘 뽑히네요! 제가 토요일에 출국 일정이 있어서 일찍 고쳐주시면 제가 얼른 리뷰해보겠습니다!
|
@choincnp 님 리뷰 감사합니다! 말씀 주신 내용 수정하였으니 확인 부탁드립니다 :)
바쁘신 와중 꼼꼼한 리뷰에 다시 한 번 감사드립니다! |
choincnp
reviewed
Jan 24, 2025
There was a problem hiding this comment.
@MoonHeesun 고생하셨어요. 지금 Approve 드려도 이미지 갈면 다시 초기화돼서, 그때 discord 등에서 멘션 다시 한번 주시겠어요?
sunworl
requested changes
Jan 24, 2025
There was a problem hiding this comment.
🖥️ OS: Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: {Write freely, 한국어 기술 가능}
수고 많으셨습니다.
에러 없이 작동하였습니다.
제안 한 가지 드렸습니다. 기능상 필요한건 아닙니다.
기여자 프로필 작성 가이드에 따라 디자이너 추가 및 리뷰어 삭제
choincnp
approved these changes
Jan 24, 2025
chaeyoonyunakim
approved these changes
Jan 24, 2025
f23293f
into
LangChain-OpenTutorial:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{PR Message - Write freely, remove this bracket if unnecessary}
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N