Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

choincnp
Copy link
Contributor

안녕하세요, 열심히 개발했습니다. 잘 부탁드립니다.

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@choincnp choincnp changed the title Tutorial lang graph temp [E-4] 17-LangGraph/03-Use-Cases/01-LangGraph-Agent-Simulation Jan 22, 2025
@chaeyoonyunakim chaeyoonyunakim self-requested a review January 23, 2025 07:20
@chaeyoonyunakim chaeyoonyunakim added docs tutorial proofreading 번역/검수팀 제안사항 반영 labels Jan 23, 2025
Copy link
Contributor

@ranian963 ranian963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Mac
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}

안녕하세요 이번주도 고생 많으셨습니다.
몇가지 간단한 수정이 되면 좋을것 같습니다.

  1. package.install 항목에 "langchain_openai", "langchain_community", 2개가 추가되어야 할것 같습니다.
  2. Define Agent Simulation 아래에 한국어가 있습니다.

@choincnp
Copy link
Contributor Author

@ranian963 안녕하세요,해당부분 수정 완료했습니다. 감사합니다 :)

@Jae-hoya
Copy link
Contributor

Jae-hoya commented Jan 24, 2025

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}

고생 많으셨습니다.

@chaeyoonyunakim chaeyoonyunakim removed the proofreading 번역/검수팀 제안사항 반영 label Jan 24, 2025
Copy link
Contributor

@ranian963 ranian963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Mac
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}

이번주도 고생 많으셨습니다.
수정확인하였습니다.
연휴 잘보내세요

@teddylee777 teddylee777 merged commit 16df2e2 into LangChain-OpenTutorial:main Jan 25, 2025
1 of 2 checks passed
@choincnp choincnp deleted the tutorial-LangGraph-temp branch February 20, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants