Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ranian963
Copy link
Contributor

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

…remove this bracket if unnecessary}\n\n### Author Checklist\n- [x] **PR Title Format**: I have confirmed that the PR title follows the correct format. _(e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)_\n- [x] **Committed Files**: I have ensured that no unnecessary files _(e.g., .bin, .gitignore, poetry.lock, pyproject.toml)_ are included. These files are not allowed.\n- [ ] **(Optional) Related Issue**: If this PR is linked to an issue, I have referenced the issue number in the PR message. _(e.g., Fixes LangChain-OpenTutorial#123)_\n      \n- ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.\n\n### Review Template (Intial PR)\n\nIf no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N
키 입력에 빈 문자열 빠진것을 추가하였습니다.
@ranian963
Copy link
Contributor Author

@gyjong 안녕하세요
ipynb 파일만 수정했는데 이전 pr이 자동으로 close 되어버려서 다시 pr을 올리게 되었습니다.
이전에 많이 봐주셨는데 사라진거 같아 죄송합니다.
말씀주신대로 키에 빠진 "",들을 추가하였습니다.
리뷰에 chaeyoonyunakim님을 추가하였습니다.

감사합니다!!

@chaeyoonyunakim chaeyoonyunakim added docs tutorial proofreading 번역/검수팀 제안사항 반영 labels Jan 23, 2025
Copy link
Contributor

@gyjong gyjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review Checklist]

  • Review OS: Mac
  • Template Rule 준수 여부: Template Rule 가이드를 준수
  • Table of Contents 링크 확인: Table of Contents의 링크가 원활하게 동작
  • 이미지 파일명 검토: 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수
  • 최신 import 방식 사용 여부: import 구문이 최신 버전
  • 코드 동작 확인: 모든 코드가 오류 없이 동작
  • 제출 파일 확인: 꼭 필요한 파일들만 제출
  • 기타 의견: 내용이 많은데 코드 작성과 영문화에 수고 많으셨습니다.

@Jae-hoya
Copy link
Contributor

Jae-hoya commented Jan 24, 2025

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}

고생많으셨습니다.

Copy link
Contributor

@chaeyoonyunakim chaeyoonyunakim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요, 번역/검수 확인입니다. gpt-4o-mini 표기가 40로 오기되어 수정 요청드립니다. 그리고 저는 plan-and-executeexecution agent강조 사용으로 판단하여 backtick 사용 사례가 맞는지 확인 부탁드립니다.

gpt 모델 오타 수정 commit이 된다는 가정하에 추가로 개요 (Overview) 문단을 조금 다르게 작성해 제안드립니다: This tutorial provides a step-by-step guide on creating a plan-and-execute style agent with LangGraph. The plan-and-execute approach is useful for tackling complex tasks because it involves creating an initial plan, executing the steps of that plan, and then revising the plan based on the results of each step as needed. 판단에 따라 원고 수정이 없어도 무방한 부분입니다. 감사합니다.

"\n",
"> **Note** \n",
"> 1. Since `MODEL_NAME` appears frequently, we declare it as a separate variable. \n",
"> 2. It is recommended to run this with a model such as `gpt-4o` (or another GPT-4-level model). If you use a smaller model like `gpt-40-mini`, you may encounter frequent replanning.\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpt-4o-mini

@teddylee777 teddylee777 merged commit 979799a into LangChain-OpenTutorial:main Jan 26, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs tutorial proofreading 번역/검수팀 제안사항 반영
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants