Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

suhyun0115
Copy link
Contributor

@suhyun0115 suhyun0115 commented Jan 23, 2025

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@suhyun0115 suhyun0115 added the proofreading 번역/검수팀 제안사항 반영 label Jan 23, 2025
@sooyoung-wind sooyoung-wind added the GitBook uploading gitbook in docs label Jan 24, 2025
Copy link
Contributor

@sooyoung-wind sooyoung-wind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max_iters을 30에서 3으로 줄인 것을 확인했습니다.
@suhyun0115 이건 제 개인적인 궁금증인데요. 30까지 돌리면 성능이 좋아지나요?

@teddylee777
Copy link
Contributor

@sooyoung-wind Debate 하는 max 횟수를 3 -> 30 으로 늘리는 건데
늘리면 토론이 산으로 갈때도 있고요,
토큰 비용도 과도하게 나올 수 있어 너무 크게 늘리는 것은 오히려 좋지 않습니다.

Copy link
Contributor

@teddylee777 teddylee777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요청사항 반영하시느라 정말 고생 많으셨습니다.
merge 하도록 하겠습니다.

@teddylee777 teddylee777 merged commit c5347b5 into LangChain-OpenTutorial:main Jan 24, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitBook uploading gitbook in docs proofreading 번역/검수팀 제안사항 반영
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants