Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

leebeanbin
Copy link
Contributor

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

Comment : This tutorial refers to new one in LangGraph docs with Memory definition for LLM but it was not also in our wiki docs

[Title] 16-LangGraph-SemanticSearch
[Version] Initial
[Language] ENG
[Packages] langchain, langchain_openai, langchain_community, langgraph

- add langgraph tutorial that was not in wikidocs but it was existed in LangGraph docs with Memory for LLM
[Title] 16-LangGraph-SemanticSearch
[Version] Initial
[Language] ENG
[Packages] langchain, langchain_openai, langchain_community, langgraph

- add langgraph tutorial that was not in wikidocs but it was existed in LangGraph docs with Memory for LLM
- move folder location to core-feature
@leebeanbin leebeanbin self-assigned this Jan 24, 2025
@leebeanbin leebeanbin requested review from brian604 and acho98 January 24, 2025 01:18
@leebeanbin leebeanbin changed the title [N-3] / [17-LangGraph]/ 16-LangGraph-SemanticSearch [Title] 16-LangGraph-SemanticSearch [N-3] / [17-LangGraph]/ 16-LangGraph-SemanticSearch Jan 24, 2025
Copy link
Contributor

@acho98 acho98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Advanced Memory Features
위 부분의 링크가 동작하지 않습니다.

@brian604
Copy link
Contributor

🖥️ OS: Mac
✅ Checklist

  • [ x ] Template: Tutorials follows the required template.
  • [ ] Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • [ NA ] Image: Image filenames follow guidelines.
  • [ ] Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • [ x ] Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}

@leebeanbin
Check the TOC links to work.

I could not execute the function "visualize_graph" from langchain_opentutorial.
I have just upgraded package by using poetry upgrade.
Other than that, I believed code runs without much of the errors.

image

However, I spotted some outputs to re-consider.

  1. langchain-opentutorial issue
image 2. Explicit naming of the model for HuggingFace Embedding image

"- Peer Review: [Jiwon Kim](https://github.com/brain604), [ByungGil Yoon](https://github.com/acho98)\n",
"- This is a part of [LangChain Open Tutorial](https://github.com/LangChain-OpenTutorial/LangChain-OpenTutorial)\n",
"\n",
"[![Open in Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/LangChain-OpenTutorial/LangChain-OpenTutorial/blob/main/16-Evaluations/02-Evaluation-using-RAGAS.ipynb) [![Open in GitHub](https://img.shields.io/badge/Open%20in%20GitHub-181717?style=flat-square&logo=github&logoColor=white)](https://github.com/LangChain-OpenTutorial/LangChain-OpenTutorial/blob/main/16-Evaluations/02-Evaluation-using-RAGAS.ipynb)\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the link accordingly.
Same to "Open in Github"

"## Memory Management Approaches in LangGraph\n",
"\n",
"### Different Memory Systems\n",
"- `Checkpointing`: State persistence with thread management\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to bold which is "**" that encloses the word around in markdown format

@teddylee777 teddylee777 closed this pull request by merging all changes into LangChain-OpenTutorial:main in 8d4a955 Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants