[N-1] / [06-DocumentLoader]/09-JSONLoader #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Title] JSONLoader [Version] Proofread fix [Language] ENG [Packages] langchain, langchain_openai, langchain_community, rq - recommit this file
[Title] JSONLoader [Version] Review fix [Language] ENG [Packages] langchain, langchain_openai, langchain_community, rq - add backticks on JSONLoader and proofreaded Naming rules for tutorial
[Title] 16-LangGraph-SemanticSearch [Version] Initial [Language] ENG [Packages] langchain, langchain_openai, langchain_community, langgraph - add langgraph tutorial that was not in wikidocs but it was existed in LangGraph docs with Memory for LLM
[Title] 16-LangGraph-SemanticSearch [Version] Initial [Language] ENG [Packages] langchain, langchain_openai, langchain_community, langgraph - add langgraph tutorial that was not in wikidocs but it was existed in LangGraph docs with Memory for LLM - move folder location to core-feature
[Title] 09-JSONLoader [Version] re pull request [Language] ENG [Packages] langchain, langchain_openai, langchain_community, rq - remove and re-pull request json_parser
|
@leebeanbin 님 안녕하세요~ 몇가지 수정 사항이 있어서 코멘트를 남기게 되었습니다 ㅎㅎ 환경설정 부분이 잘못 들어간 것 같습니다! 위에 있는 부분은 삭제 해주셔도 될 것 같아요.
제 생각에는 1,2번의 경우 함수명/변수명/모듈명에 해당되지 않는 것 같습니다..!! 그래서 bold처리를 하는 것이 더 적절해 보입니다. 이 부분의 경우 정빈님께서 한번 검토 후 수정 반영 해주시면 감사하겠습니다! |
[Title] 09-JSONLoader [Version] Second [Language] ENG [Packages] langchain, langchain_openai, langchain_community, rq - add backticks - modify unnecessary parts of explain.
8 tasks
chaeyoonyunakim
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
https://github.com/LangChain-OpenTutorial/LangChain-OpenTutorial/pull/423에서 이미 승인된 사항들 conflict issue 해결 건입니다
kkam-dragon
approved these changes
Jan 25, 2025
BokyungisaGod
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{PR Message - Write freely, remove this bracket if unnecessary}
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N
Comment: I, first of all, closed the last pr and reopened this again to push only the JSON loader file.