Thanks to visit codestin.com
Credit goes to github.com

Skip to content

06-DocumentLoader-Word-Loader #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 2, 2025
Merged

06-DocumentLoader-Word-Loader #7

merged 12 commits into from
Jan 2, 2025

Conversation

suhyun0115
Copy link
Contributor

[Team] 신규1팀
[Title] 06-DocumentLoader-Word-Loader
[Version] initial
[Language] ENG
[Packages] python-docx, langchain, docx2txt

This Pull Request introduces functionality to load Word documents (.docx) using the DocumentLoader module. Key changes include:

  1. Implemented a new function to read and parse .docx files.
  2. Updated related modules to integrate the Word document loader.
  3. Added test cases to validate .docx processing.

Please review the following:

  • The function implementation in Word-Loader.ipynb.
  • Test case coverage for edge cases in .docx file handling.

@teddylee777 teddylee777 self-requested a review December 29, 2024 12:17
teddylee777
teddylee777 approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@teddylee777 teddylee777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colab 에서 테스트 하였습니다.
튜토리얼 작성 내용도 충실하여 좋습니다.
문제 없이 잘 동작합니다.
고생하셨습니다.
approval.

@seofield
Copy link
Contributor

seofield commented Jan 1, 2025 •
edited
Loading

[Review]

Review OS(Windows/Mac/Linux): Mac
Template Rule 가이드를 준수 하였는가(YES/NO): YES
Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?(YES/NO): YES
이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?(YES/NO): YES
import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?(YES/NO): YES
모든 코드가 동작에 오류 없이 동작하는가? (만약, warning 발생시 코멘트에 적어주세요): YES
기타의견:

수고하셨습니다~

@BAEM1N BAEM1N merged commit 0d34992 into LangChain-OpenTutorial:main Jan 2, 2025
2 of 3 checks passed
architectyou
architectyou reviewed Jan 3, 2025
View reviewed changes
Copy link
Member

@architectyou architectyou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review] - WordLoader

Review OS: Mac
Template Rule 가이드를 준수 하였는가: yes
Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?: yes
이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?: N/A
import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?: yes
모든 코드가 동작에 오류 없이 동작하는가? (만약, warning 발생시 코멘트에 적어주세요): yes
기타 의견:

  • 전반적으로 디테일하게 내용 꽉꽉 담아 작성해주신 것 같습니다!!
  • ipynb 파일 파일명에 순서 함께 붙여 통일감 주시면 좋을 것 같습니다. (06번)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@architectyou architectyou architectyou left review comments

@teddylee777 teddylee777 teddylee777 approved these changes

@seofield seofield seofield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@suhyun0115 @seofield @teddylee777 @architectyou @BAEM1N