[N-3]06-DocumentLoader/14-BiorxivLoader #708
Conversation
…ust few lines of code. 02/19/25
There was a problem hiding this comment.
작동엔 이상이 없으나 내용 관련하여 약간의 보완이 이뤄지면 좋을 것 같습니다.
🖥️ OS: Mac
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: 고생하셨습니다!
| "source": [ | ||
| "## Example Queries\n", | ||
| "\n", | ||
| "In this step, we will test out few examples to see if the biorxiv loader works as expected so it has a potential to contribute to `langchain_community`\n", |
There was a problem hiding this comment.
"if the biorxic loader works as expected so it has a potential to contribute to langchain_community"라는 문장 의미가 다소 불명확한 것 같습니다. 어떤 뜻으로 적으신 걸까요?
There was a problem hiding this comment.
Arxiv는 langchain에서는 (langchain_community) 형태로 서포트가 되지만, biorxiv, medrxiv와 같은 생명과학자들을 위한 패키지는 없어서 많이 아쉬워서 표현을 이러한 식으로 한것입니다.
There was a problem hiding this comment.
네 취지는 이해하였는데요, langchain_community 패키지와 무관해보이는데 해당 코드에 contribution한다는 의미로 읽혀서 여쭤보았습니다. 아래와 같이 수정해보면 어떨까 싶습니다:
In this step, we will test out few examples to see if the biorxiv loader works as expected to other document loaders in
langchain_community.document_loaders.
| "## Example Queries\n", | ||
| "\n", | ||
| "In this step, we will test out few examples to see if the biorxiv loader works as expected so it has a potential to contribute to `langchain_community`\n", | ||
| "- We will test the date range from server \"biorxiv\" for the period from 2024-01-01 to 2024-02-17" |
There was a problem hiding this comment.
실제 코드는 총 3번의 쿼리를 통해 simple keyword search, w/date range, w/recent date range를 조회하고 있어서 이를 여기에 반영하거나, 각 검색 쿼리에 대한 코드블럭을 나눠서 각각 설명해주시는 것도 좋을 것 같습니다.
또한, 다른 document loader tutorial을 참고하여 search 함수의 파라미터를 설명해주는 게 좋을 것 같아 제안드립니다.
{PR Message - Write freely, remove this bracket if unnecessary}
Author Checklist
[ x ] PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
[ x ] Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
[ x ] (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N