[E-4] 05-MEMORY / 05-ConversationKGMemory #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Title] ConversationKGMemory [Version] initial [Language] ENG [Package] langchain, langchain-community, langchain-openai ConversationKGMemory Tutorial Implementation - Introducing ConversationKGMemory to manage conversation entities and relationships in graph structure - Demonstrated key features: save_context, get_current_entities, get_knowledge_triplets, load_memory_variables - Showed practical example with a conversation scenario about a new employee - Provided integration example with ConversationChain
jinucho
previously approved these changes
Jan 1, 2025
There was a problem hiding this comment.
[Review]
- Review OS(Windows/Mac/Linux): MAC
- Template Rule 가이드를 준수 하였는가(YE S/NO): YES
- Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?(YES/NO): YES
- 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?(YES/NO): N/A
- import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?(YES/NO): YES
- 모든 코드가 동작에 오류 없이 동작하는가? (만약, warning 발생시 코멘트에 적어주세요):
conversation_with_kg = ConversationChain(
llm=llm, prompt=prompt, memory=ConversationKGMemory(llm=llm)
) 에서 The classConversationChainwas deprecated in LangChain 0.2.7 and will be removed in 1.0. 경고 발생
Add new section demonstrating KG Memory implementation using LCEL (LangChain Expression Language) as ConversationChain will be removed in LangChain 1.0. The new section: - Preserves existing ConversationChain example for reference - Adds modern implementation using LCEL - Provides same functionality with future-proof approach This addition helps users transition from deprecated ConversationChain to LCEL-based implementation.
|
@jinucho 기존 ConversationChain 활용 섹션 뒤에 LCEL을 통해 해당 체인을 구현, 활용하는 섹션을 추가했습니다! |
jinucho
previously approved these changes
Jan 2, 2025
There was a problem hiding this comment.
[Review]
- Review OS(Windows/Mac/Linux): MAC
- Template Rule 가이드를 준수 하였는가(YE S/NO): YES
- Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?(YES/NO): YES
- 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?(YES/NO): N/A
- import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?(YES/NO): YES
- 모든 코드가 동작에 오류 없이 동작하는가? (만약, warning 발생시 코멘트에 적어주세요) Yes
ConversationChain deprecated 경고에 따른 추가 코드를 작성 해주셨습니다.
ulysyszh
requested changes
Jan 2, 2025
There was a problem hiding this comment.
고생 많으셨습니다~
Review OS(Windows/Mac/Linux): Linux
Template Rule 가이드를 준수 하였는가(YE S/NO): YES
Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?(YES/NO): YES
이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?(YES/NO): N/A
import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?(YES/NO): NO
모든 코드가 동작에 오류 없이 동작하는가? YES
from langchain_core.prompts import PromptTemplate
…de cell - The tutorial now provides clearer guidance on how each method works and what to expect from their execution. - Added the explanation of get_knowledge_triplets
jinucho
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
[Review]
- Review OS(Windows/Mac/Linux): MAC
- Template Rule 가이드를 준수 하였는가(YE S/NO): YES
- Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?(YES/NO): YES
- 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?(YES/NO): N/A
- import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?(YES/NO): YES
- 모든 코드가 동작에 오류 없이 동작하는가? (만약, warning 발생시 코멘트에 적어주세요) Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Title] ConversationKGMemory
[Version] initial
[Language] ENG
[Package] langchain, langchain-community, langchain-openai
ConversationKGMemory Tutorial Implementation