[E-1] 1.Basic-01. Follow the Installation Video_Windows #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Team] 기존1Team [Title] 01. Follow the Installation Video_Windows [Version] Ver1 [Language] ENG [Packages] git, pyenv, Poetry, Visual Studio Code
[Team] 기존1Team [Title] 01. Follow the Installation Video_Windows [Version] Ver1 [Language] ENG [Packages] git, pyenv, Poetry, Visual Studio Code
[Team] 기존1Team [Title] 01. Follow the Installation Video_Windows [Version] Ver1 [Language] ENG [Packages] git, pyenv, Poetry, Visual Studio Code
|
기존 PR45를 대체합니다. |
r14minji
requested changes
Jan 3, 2025
There was a problem hiding this comment.
[Review]
- Review OS: Windows
- Template Rule 가이드를 준수 하였는가: YES
- Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?: YES
- 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?: NO
- 이미지 파일명 가이드에 따라
01-follow-the-installation-video-windows-0X.png
- import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?: YES
- 모든 코드가 동작에 오류 없이 동작하는가? : Yes
- 기타 의견:
- ipynb 파일명도 변경되어야하는 것같습니다.
01-FollowTheInstallationVideoWindows.ipynb - 중간 중간 이미지가 다음 텍스트와 연결되어 보여지는데요, 확인 요청드립니다.
|
[Review] Review OS: Mac
import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?: YES |
[Version] Ver3 [Language] ENG [Packages] git, pyenv, Poetry, Visual Studio Code
[Version] Ver4: 이미지명 수정했습니다. [Language] ENG [Packages] git, pyenv, Poetry, Visual Studio Code
[Version] 주피터노트북, 이미지명 변경 [Language] ENG [Packages] git, pyenv, Poetry, Visual Studio Code
yuneun92
approved these changes
Jan 3, 2025
r14minji
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Team] 기존1Team
[Title] 01. Follow the Installation Video_Windows
[Version] Ver2
[Language] ENG
[Packages] git, pyenv, Poetry, Visual Studio Code