[N-3] 08-Embedding / 04-UpstageEmbeddings #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pupba
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
[Review]
- Review OS(Windows/Mac/Linux): Window
- Template Rule 가이드를 준수 하였는가(YES/NO): YES
- Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?(YES/NO): YES
- 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?(YES/NO): YES
- import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?(YES/NO): YES
- 모든 코드가 동작에 오류 없이 동작하는가? (만약, warning 발생시 코멘트에 적어주세요): YES
- 기타 의견:
Peer Review추가해서 커밋했습니다. 고생하셨습니다!
krkrong
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
[Review]
- Review OS(Windows/Mac/Linux): Mac
- Template Rule 가이드를 준수 하였는가(YES/NO): YES
- Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?(YES/NO): YES
- 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?(YES/NO): YES
- import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?(YES/NO): YES
- 모든 코드가 동작에 오류 없이 동작하는가? (만약, warning 발생시 코멘트에 적어주세요): YES
- 기타 의견: 고생 많으셨습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
처음이라 많이 부족합니다. 피드백 감사히 받겠습니다.
다들 고생많으십니다!