Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

pupba
Copy link
Contributor

@pupba pupba commented Apr 5, 2025

  • vectorstore interface notebook template file
  • unified content structure

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

- vectorstore interface notebook template file
- unified content structure
@pupba pupba requested a review from sohyunwriter April 5, 2025 17:14
- Add a query to the `search` usage code.
@BokyungisaGod
Copy link
Contributor

@pupba 님 안녕하세요! 몇가지 수정사항이 있습니다.
1.
스크린샷 2025-04-28 오후 3 12 29

Table of contents에는 ## 까지만 작성해주세요!

  1. backtick은 3개씩 작성해주세요!
스크린샷 2025-04-29 오후 1 09 26

ex) hi -> hi

  1. backtick 뒤에 한칸 띄우기 -> 따로 하지 않아도 됩니다!

위 사항들만 수정해주시면 될 것 같고, 커밋 주시면 approve 하겠습니다 : )

@pupba pupba changed the title [N-2] 09-Vector Store / 99-Mater-Template [N-2] 09-Vector Store / 99-Master-Template Apr 29, 2025
- Remove `###` content in `Table of content`.
- ` -> ``` changed backtick
@pupba
Copy link
Contributor Author

pupba commented Apr 29, 2025

안녕하세요 @BokyungisaGod 님!
리뷰 해주신 내용 수정했습니다.
그런데 3번의 경우는 백틱 이후에 띄어쓰기 안 하면 어색해 보이더라고요.... 그래서 해당 내용은 그대로 뒀는데 괜찮을까요?

@pupba pupba requested a review from BokyungisaGod April 29, 2025 14:00
@BokyungisaGod
Copy link
Contributor

넵 괜찮습니다 : ) 수고하셨습니다

BokyungisaGod
BokyungisaGod previously approved these changes May 3, 2025
Copy link
Contributor

@BokyungisaGod BokyungisaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 :)

pupba added 2 commits May 5, 2025 08:19
- add `as_retriever` : LightCustomRetriever for tutorial
     - Fixed Master-Template
     - vectordbinterface.py
@pupba
Copy link
Contributor Author

pupba commented May 5, 2025

기존 LangChain에 호환되면서 저희 CRUD Manager로 사용할 수 있는 경량 retriever 클래스 추가했습니다.

@sohyunwriter sohyunwriter merged commit ae01a19 into LangChain-OpenTutorial:main May 6, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants