Update embedding notebooks #867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the notebook links in various files to match the recently renamed notebooks for consistent file references.
- Updated markdown links in over 20 notebooks to reflect the new notebook names.
- Adjusted the placeholder URL in the issue template to match the new file naming conventions.
Reviewed Changes
Copilot reviewed 75 out of 75 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| 06-DocumentLoader/07-PowerPointLoader.ipynb | Updated Colab and GitHub links to use the new file name. |
| 06-DocumentLoader/05-ExcelLoader.ipynb | Updated link references to reflect the renaming. |
| 06-DocumentLoader/04-CSVLoader.ipynb | Fixed file name in links to remove extra hyphens. |
| 06-DocumentLoader/03-WebBaseLoader.ipynb | Corrected link to match the new filename. |
| 04-Model/*.ipynb (multiple files) | Updated links in various model-related notebooks. |
| 02-Prompt/04-Personal-Prompts.ipynb | Adjusted link to include the hyphen in the new filename. |
| 01-Basic/*.ipynb (multiple files) | Modified links in basic notebooks to match updated names. |
| .github/ISSUE_TEMPLATE/Proofread.yml | Corrected the placeholder URL to point to the renamed file. |
Signed-off-by: Emmanuel Ferdman <[email protected]>
|
@teddylee777 I noticed that @BAEM1N addressed most of the issues in a recent commit (aad97b5). A few items were still missing, so I updated this PR with the latest changes and relevant fixes. When you have a chance, I’d appreciate it if you could take a look. |
BAEM1N
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Commit f6f0ce7 renamed
EmbeedingtoEmbeddingand renamed other notebooks. This PR adjusts sources to changes.Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N