Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

pupba
Copy link
Contributor

@pupba pupba commented May 6, 2025

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

HotFix

  • 기존 What is {vectordb}? 파트 작성이 따로 템플릿에 따로 표기되어 있지 않아 신규 작성시 빼먹을 수 있다고 판단되어 섹션을 추가했습니다.

  • Data 로딩 부분에서 기존 코드상에서 경로 오류가 있었습니다. 수정하여 오류 해결했습니다.

변경전

# Load the entire text file
with open("the_little_prince.txt", "r", encoding="utf-8") as f:
    content = f.read()

변경후

# Load the entire text file
with open("./data/the_little_prince.txt", "r", encoding="utf-8") as f:
    content = f.read()

pupba added 6 commits April 6, 2025 02:11
- vectorstore interface notebook template file
- unified content structure
- Add a query to the `search` usage code.
- Remove `###` content in `Table of content`.
- ` -> ``` changed backtick
- add `as_retriever` : LightCustomRetriever for tutorial
     - Fixed Master-Template
     - vectordbinterface.py
- HotFix
    - Add `What is {vectordb}?`
    - Changed `with open("the_little_prince.txt"~` -> `with open("./data/the_little_prince.txt"~`
@pupba pupba requested a review from sohyunwriter May 6, 2025 12:57
@pupba pupba added the hot fix Quick fix on something label May 6, 2025
@sohyunwriter sohyunwriter merged commit fc7c4ed into LangChain-OpenTutorial:main May 6, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot fix Quick fix on something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants