Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

IHAGI-c
Copy link
Contributor

@IHAGI-c IHAGI-c commented May 6, 2025

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@IHAGI-c IHAGI-c requested a review from sohyunwriter May 6, 2025 14:41
Copy link
Contributor

@sohyunwriter sohyunwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후에 delete 부분 한 번만 확인해주세요!!

delete 함수가 인자로 받을 수 있는게 ids, filters 
1) ids만 입력받은 경우 ids 있는 경우에 한해 삭제 (ids가 없어도 에러 뜨지 않도록 처리)
2) ids, filters 둘다 입력 받은 경우 ids & filters로 삭제, 즉 ids 중 필터링 걸린 걸 삭제
3) filters만 입력 받은 경우 filters로 삭제
4) 아무것도 입력받지 않은 경우 -> 전체 삭제

@sohyunwriter sohyunwriter merged commit 2e57b0c into LangChain-OpenTutorial:main May 6, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants