[N-2] 09-VectorStore / 02-Chroma #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- HotFix : add print delete count.
- delete logic Change
- Delete logic Changed..
sohyunwriter
approved these changes
May 8, 2025
There was a problem hiding this comment.
delete 수정하셨군요ㅋㅋㅋ 수고 많으셨습니다.
코드 잘 실행되는 거 확인했습니다.
아래는 추후 다른 파일 수정 시 참고용으로 디스코드 내용 복붙해놓을게요.
delete 함수가 인자로 받을 수 있는게 ids, filters
1) ids만 입력받은 경우 ids 있는 경우에 한해 삭제 (ids가 없어도 에러 뜨지 않도록 처리)
2) ids, filters 둘다 입력 받은 경우 ids & filters로 삭제, 즉 ids 중 필터링 걸린 걸 삭제
3) filters만 입력 받은 경우 filters로 삭제
4) 아무것도 입력받지 않은 경우 -> 전체 삭제
*삭제는 기본적으로 return 값이 없는 게 맞으나, 삭제 후에 "몇 개가 삭제됐는지" 메시지 띄어주기
1de7df7
into
LangChain-OpenTutorial:main
0 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N
Update