Switch from using .zip to .tar.gz for basset archives #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uuu that's brilliant! Thanks @jnoordsij |
|
Nice! Basset supports both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
The
@bassetArchivecalls where using the.zipformat. This is not supported by default on all PHP installations (see also Laravel-Backpack/basset#60).AFTER - What is happening after this PR?
Use the
.tar.gzformat, which was also available for these archives, and is enabled in PHP by default on all installations (see https://www.php.net/manual/en/phar.installation.php).HOW
How did you achieve that, in technical terms?
Change the archive extensions.
Is it a breaking change or non-breaking change?
No.
How can we test the before & after?
Ensure assets still work fine.