Thanks to visit codestin.com
Credit goes to github.com

Skip to content

✨ chore: ignore pr title linting on pull requests from dependabot #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fuadop
Copy link
Contributor

@fuadop fuadop commented May 25, 2022

PR Checklist

Overview

  • Revert dependabot to use default naming standards/convention
  • Ignore PRs from dependabot on pr title linting CI

@@ -10,6 +10,3 @@ updates:
labels:
- "npm"
- "dependencies"
commit-message:
prefix: ":arrow_up: build"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh can we keep this actually? And just change it to the direct emoji, ⬆, rather than :arrow_up:? I do like the emojis in the PR titles 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's true.. Let it keep looking pretty 😉

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but what do you think about keeping the emoji in there? 😄

@fuadop
Copy link
Contributor Author

fuadop commented May 25, 2022

LGTM, but what do you think about keeping the emoji in there? smile

Yea, I like that too. I have added the emoji 💪🏾

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⬆️ 🚀

@JoshuaKGoldberg JoshuaKGoldberg merged commit 88c1723 into LearningTypeScript:main May 25, 2022
@JoshuaKGoldberg
Copy link
Contributor

@all-contributors please add @fuadop for bug fixes

@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've updated the pull request to add @fuadop! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot prefix character limit
2 participants