Add Norwegian Nynorsk translation#1102
Merged
Merged
Conversation
Collaborator
|
They are included and visible to the user, It is just a shorter version of the longer names on places where we have less screen real estate. |
MV-GH
reviewed
Jul 27, 2023
Contributor
Author
OK. Though it looks like a ‘Top All’ string is missing at That is, |
Collaborator
|
It indeed does, you can add it if you want |
Collaborator
|
|
MV-GH
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here‘s a complete translation of Jerboa into Norwegian Nynorsk.
I have a question about some of the sorting strings, though. They look like this:
They look like internal, machine-readable strings, which should not be translated or translatable, i.e., should not be present in
strings.xml. Are they included by mistake?I did, however, translate them (as similar machine-friendly strings), as I see they are translated in string files for the other languages.
Note that there are also corresponding ‘human-friendly’ strings included, e.g., ‘New Comments’ and ‘Top Month’. And these are the ones actually used in the UI. One exception is
TopAll, which doesn’t have a human-friendly version in (‘Top All’) instrings.xml. And in the UI in the app, the option is indeed listed as ‘TopAll’, while all the other sorting options are listed using the human-friendly versions.