Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use marquee for instance in topbar, and add it to communitysidebar#1107

Merged
twizmwazin merged 4 commits into
LemmyNet:mainfrom
MV-GH:feat/instance_to_community
Aug 2, 2023
Merged

Use marquee for instance in topbar, and add it to communitysidebar#1107
twizmwazin merged 4 commits into
LemmyNet:mainfrom
MV-GH:feat/instance_to_community

Conversation

@MV-GH

@MV-GH MV-GH commented Jul 27, 2023

Copy link
Copy Markdown
Collaborator

I prefer this over the ellipsis

studio64_qSgARiKF5N.mp4

@twizmwazin

Copy link
Copy Markdown
Contributor

I'm not sure I like it tbh. I'd rather have a long-press action that revealed the full name if needed rather than have it persistently scrolling.

@MV-GH

MV-GH commented Jul 27, 2023

Copy link
Copy Markdown
Collaborator Author

It only does the scrolling thing when names are too long 99% it does not show, and any other action needs UX changes so that users will know they can do an action

@twizmwazin twizmwazin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after rebase

@twizmwazin twizmwazin enabled auto-merge (squash) August 2, 2023 15:09
@MV-GH

MV-GH commented Aug 2, 2023

Copy link
Copy Markdown
Collaborator Author

Tbh I am not a fan of it either but I still prefer it over the ellipsis thing as the point of these changes are so that you can see the instance that community is from. And ellipsis prevents it. Ideally we add it somewhere else on a better place. And then we can revert these topbar changes and have it the name only. But this works for now.

@twizmwazin twizmwazin merged commit 0e6fd51 into LemmyNet:main Aug 2, 2023
@MV-GH MV-GH deleted the feat/instance_to_community branch August 7, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants