Support private tabs for FireFox#1216
Merged
Merged
Conversation
Extra read here: https://github.com/mozilla-mobile/firefox-android/blob/fenix-v117.0/fenix/app/src/main/java/org/mozilla/fenix/IntentReceiverActivity.kt#L65 Key defined here: https://github.com/mozilla-mobile/firefox-android/blob/fenix-v117.0/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt#L1290
MV-GH
requested changes
Sep 4, 2023
MV-GH
left a comment
Collaborator
There was a problem hiding this comment.
Add this in the else section of the useCustomTab
if (usePrivateTab) {
intent.putExtra("com.google.android.apps.chrome.EXTRA_OPEN_NEW_INCOGNITO_TAB", true)
intent.putExtra("private_browsing_mode", true)
}It is supposed to work too if you don't use a customtab
Contributor
Author
The option in the menu is "Use private custom tabs if available" so I just followed the current pattern for Chrome. This makes a lot of sense though, so I've changed this to always send the extras if the option is set, and update the option in the menu |
MV-GH
requested changes
Sep 4, 2023
MV-GH
approved these changes
Sep 4, 2023
dessalines
approved these changes
Sep 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extra read here:
https://github.com/mozilla-mobile/firefox-android/blob/fenix-v117.0/fenix/app/src/main/java/org/mozilla/fenix/IntentReceiverActivity.kt#L65
Key defined here:
https://github.com/mozilla-mobile/firefox-android/blob/fenix-v117.0/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt#L1290