Fix zooming difficulties#1237
Merged
Merged
Conversation
dessalines
approved these changes
Sep 15, 2023
dessalines
left a comment
Member
There was a problem hiding this comment.
I tested it out now, its a little fidgety (IE sometimes when you 2-finger-zoom it thinks its flicking away, but still better than what it was.
dessalines
added a commit
that referenced
this pull request
Sep 15, 2023
This reverts commit a4beb5d.
dessalines
added a commit
that referenced
this pull request
Sep 19, 2023
…in ImageViewer (#1238) * Revert "Fix zooming difficulties (#1237)" This reverts commit a4beb5d. * Remove swipe to exit in ImageViewer --------- Co-authored-by: maarten.vercruysse <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used nested scrolling before to enable flick to exit behaviour, But nested scrolling doesn't work well compose and causes subtle issues. Thus I replaced it this with library which uses dragged instead.
see https://programming.dev/post/2375491
Fixes #1232
rhgjfNohMg.mp4