Fix migration changing the the app settings#1442
Merged
Merged
Conversation
dessalines
approved these changes
Mar 11, 2024
dessalines
left a comment
Member
There was a problem hiding this comment.
Yup it is, android makes DB migrations an absolute nightmare.
I also tested this and it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is really annoying, the order of these column definitions is very important.
This caused half the settings to be switched with two columns lower.
This fixes that
It is actually miracle that this didnt cause any crashes (well if it did we would have found it earlier). I don't see how to add a test for this to prevent this from happening again.
We will have to be very careful with doing big changes to appSettings again
Fixes #1440
I have verified this with a pre 30 db version app and 31 has the exact same settings.