Reduce recompositions due to TopAppBar#1542
Merged
Merged
Conversation
dessalines
approved these changes
Jun 13, 2024
dessalines
left a comment
Member
There was a problem hiding this comment.
Hopefully some of the newer jetpack compose tutorials should really tell you about that: to not pass in padding values as it will cause a ton of these recompositions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you swipe up and down the top app bar moves. This updates the padding value. All composable which take this as param constantly recompose because the padding constantly changes as the header takes up more/less space. We can avoid that by applying it before the main composables. I had already done this for the feed. But we can do this easily already for the other screens.