Bettering torrent support.#1612
Merged
Merged
Conversation
- Fixes URI validation to include magnet link schemes. - When creating a post, can automatically copy the torrent title from the link. - Adds a torrent helper for magnet links. - Fixes magnet link clicks. - Fixes #1609
MV-GH
requested changes
Aug 5, 2024
| MetaDataRes(res.data.metadata.title, false) | ||
| else -> MetaDataRes(null, false) | ||
| // If its a torrent magnet link, use the dn param to extract the torrent title | ||
| if (uri.scheme == "magnet") { |
Collaborator
There was a problem hiding this comment.
Can you add a constant for these strings.
Member
Author
There was a problem hiding this comment.
I did add a ALLOWED_SCHEMES list, but this one only needs to check one of them.
Collaborator
|
You need to fix the tests too |
MV-GH
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pics: