Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixes mostly systembars colors not matching with application#1651

Merged
dessalines merged 1 commit into
LemmyNet:mainfrom
MV-GH:fix-mostly-wrong-systembars-colors
Sep 5, 2024
Merged

Fixes mostly systembars colors not matching with application#1651
dessalines merged 1 commit into
LemmyNet:mainfrom
MV-GH:fix-mostly-wrong-systembars-colors

Conversation

@MV-GH

@MV-GH MV-GH commented Sep 4, 2024

Copy link
Copy Markdown
Collaborator

The statusbar is not as perfect as before as it would change with the elevation color change, now not anymore.

These changes are needed:

insets.isAppearanceLightStatusBars = isLight
insets.isAppearanceLightNavigationBars = isLight

This is needed so that if you don't have system set as ThemeMode it will still set the correct (inverse) coloring of the statusbar.

window.statusBarColor = Color.Transparent.toArgb()

Needed to mimic translucentStatus. Not as good but pretty close. see #1607 removal

The navigationbar seemed to use a different container color now. So this solves that.

image

#1649

@MV-GH MV-GH requested a review from dessalines as a code owner September 4, 2024 00:11

@dessalines dessalines left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thx.

@dessalines dessalines merged commit 689d633 into LemmyNet:main Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants