Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix signout#180

Merged
dessalines merged 3 commits into
LemmyNet:mainfrom
LunaticHacker:signout
Jul 6, 2022
Merged

fix signout#180
dessalines merged 3 commits into
LemmyNet:mainfrom
LunaticHacker:signout

Conversation

@LunaticHacker

Copy link
Copy Markdown
Contributor

fix #179

@LunaticHacker LunaticHacker requested a review from dessalines as a code owner July 2, 2022 07:45
@LunaticHacker

Copy link
Copy Markdown
Contributor Author

is there a way to force the lint check locally?

@dessalines

Copy link
Copy Markdown
Member

We use husky for lemmy-ui ( and used to use cargo-husky for lemmy ), but it doesn't look like there's a husky equivalent for gradle projects :( .

You might just be able to add ./gradlew ktlintCheck to .git/hooks/pre-commit

@dessalines dessalines left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this BTW, I'm feeling spread so thin, and jerboa needs a lot of work. I'd rather spend more time on jerboa than lemmy-ui ( kotlin is better to work with than typescript, and priority should be put on native apps and not the web .

@dessalines dessalines merged commit 5dbbdde into LemmyNet:main Jul 6, 2022
LunaticHacker added a commit to LunaticHacker/jerboa that referenced this pull request Jul 14, 2022
LunaticHacker added a commit to LunaticHacker/jerboa that referenced this pull request Jul 14, 2022
dessalines pushed a commit that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

singout isn't handled properly

2 participants