Fixes #1748 Extra padding above IME keyboard#1824
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the extra padding above the IME keyboard and refactors MarkdownTextField usage by preventing duplicate modifier applications. Key changes include:
- Replacing redundant .imePadding() calls with a combination of .consumeWindowInsets(padding) and .imePadding() in the proper order.
- Removing unnecessary .fillMaxWidth() modifiers from MarkdownTextField invocations.
- Adjusting modifier chains across multiple UI components for consistent layout behavior.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| AccountSettings.kt | Updated modifier chain to add vertical scrolling and use consumeWindowInsets to prevent duplicated insets. |
| CreateReport.kt | Removed fillMaxWidth() from MarkdownTextField and introduced consumeWindowInsets into the modifier chain. |
| RemoveItem.kt | Similar change as CreateReport.kt; replaced fillMaxWidth() with consumeWindowInsets. |
| RegistrationApplications.kt | Eliminated redundant fillMaxWidth() usage on text fields. |
| PrivateMessageReplyScreen.kt | Added consumeWindowInsets to the modifier chain to correct keyboard inset behavior. |
| PrivateMessageReply.kt | Removed fillMaxWidth() from MarkdownTextField to align with the refactor. |
| CreatePrivateMessageScreen.kt | Updated modifier chain with consumeWindowInsets in place of fillMaxWidth() for consistent layout. |
| PostComposables.kt | Removed unnecessary fillMaxWidth() modifier from the text field. |
| LoginScreen.kt | Introduced consumeWindowInsets into the modifier chain for layout consistency. |
| Login.kt | Removed imePadding from the modifier chain to prevent unwanted padding behavior. |
| InputFields.kt | Revised MarkdownTextField definition to leverage a new modifier chain that ensures full width using fillMaxWidth() before focus handling. |
| CommentReplyScreen.kt | Integrated consumeWindowInsets into various modifier chains enhancing the text inputs’ layout. |
| CommentReply.kt | Removed recurring fillMaxWidth() modifiers from multiple text fields for consistent styling. |
| CommentEdit.kt | Updated modifier chain by substituting fillMaxWidth() with consumeWindowInsets to correct padding behavior. |
| BanPerson.kt | Removed redundant fillMaxWidth() modifier on the text field to streamline layout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The imePadding seemed to also apply the navigationBar padding. Using this
consumeWindowInsetsmade it only apply once.Also refactored
MarkdownTextFieldslightly to not have that required maxFillSize default as part of params and apply the same modifier twice.Fixes #1748