Add option to disable video auto play#1936
Conversation
| when { | ||
| videoPost && expandedImage -> { | ||
| videoPost && expandedImage && !disableVideoAutoplay -> { | ||
| PostTitleAndVideoLink( |
There was a problem hiding this comment.
Shouldn't this be internal to that composable? This makes it seem like you're also hiding the post title and video, rather than just not playing the video.
It should probably display a frame, and just not autoplay, if that's possible.
|
The prop drilling is annoying I agree, but I much prefer it any obfuscated param injection methods, so ya I'd like to keep all the explicit props as they are. I def would be willing to consider just passing the entire appsettings object to all the composables that need it tho (as a separate PR). Then at least we wouldn't have to define a ton of things. That also has drawbacks tho, like not being able to easily set up previews, and not being clear about what specifically the component needs. |
Most work was propdrilling that setting.
I ve been thinking about using compositionprovider to push the settings down, and only pass by arg in the relevant composables.
But that would be a lot of refactor work to setup initially and I don't know how you feel about it.
studio64_HawxxZ3ilO.mp4