Remove Splash Screen#383
Merged
Merged
Conversation
dessalines
approved these changes
Jun 4, 2023
dessalines
left a comment
Member
There was a problem hiding this comment.
Looks good, thx!
Run ./gradlew formatKotlin and push that.
New default route is now `home`, which the splash screen used to navigate to automatically.
c703c1d to
84480b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New default route is now
home, which the splash screen used to navigate to automatically.Motivation:
There's a bug causing the splash screen to relaunch when pressing the back button (#382). Removing the splash screen remedies this issue.
There's some cosmetic loss in that the current splash screen never shows any more, and some performance benefit in that users no longer need to wait 0.7 seconds before the app content shows.
The cosmetic benefits of a splash screen can be regained by implementing the
SplashScreen-API: https://developer.android.com/develop/ui/views/launch/splash-screen