Add option to show contents of collapsed comments#438
Conversation
|
Looking good so far! You might need to ping me whenever you need me to review, not sure how smartly github handles draft -> non-draft prs. |
f0b84a2 to
874486e
Compare
874486e to
8856507
Compare
|
Alright @dessalines, this should be ready! |
|
FYI I've also made a PR that fixes the comment collapsing feature I added from closing the top-level comment, which felt a bit weird/clumsy: #446 I don't mind which way we go though, just thought I'd throw it out there. :) |
|
@a1studmuffin I'm good with either, we'll have to put out a poll to see what people prefer. |
|
I'm testing the color fix right now and it should be posted in minutes. Regarding the two PRs, I obviously have a preference towards mine. However, @a1studmuffin, I wouldn't mind adding a toggle to enable the behavior in your PR so that users can choose. My design is pretty much a one-to-one copy of boost's behavior. |
dessalines
left a comment
There was a problem hiding this comment.
Thanks, looks good!
Once it passes CI we can merge, run the ./gradlew formatKotlin
dessalines
left a comment
There was a problem hiding this comment.
Thanks, looks good!
Once it passes CI we can merge, run the ./gradlew formatKotlin
Head branch was pushed to by a user without write access
Basic functionality is working, but still a few TODOs on this:
No indication if a comment is collapsed since the whole body is shown. Boost uses a little +N icon in the top bar.Comments folding isn't animated currentlySettings migrations needs to be tested