Thanks to visit codestin.com
Credit goes to github.com

Skip to content

In-app image viewer#444

Merged
dessalines merged 19 commits into
LemmyNet:mainfrom
pipe01:main
Jun 9, 2023
Merged

In-app image viewer#444
dessalines merged 19 commits into
LemmyNet:mainfrom
pipe01:main

Conversation

@pipe01

@pipe01 pipe01 commented Jun 6, 2023

Copy link
Copy Markdown
Contributor

Whenever a post's image is clicked on the home page, the full image will be opened in the image viewer, which has the usual pinch zoom and pan functionality. There's also a save button in the top right corner which will download the image to the device's pictures folder, and a back button on the top left.

Everything is working already, I'm just waiting for https://github.com/usuiat/Zoomable to release a new version which will include a couple features that I need.

Fixes #397

@TrollBlox

TrollBlox commented Jun 7, 2023

Copy link
Copy Markdown

What if you put the button in the top right and add a back button in the top left? just a suggestion

@pipe01

pipe01 commented Jun 7, 2023

Copy link
Copy Markdown
Contributor Author

Oops yeah sorry, the download button is on the top right, not top left. On the top left there's a back button as you said.

@TrollBlox

Copy link
Copy Markdown

I can't wait to see this in the app! Is all that's left waiting for a new version of Zoomable?

@pipe01

pipe01 commented Jun 7, 2023

Copy link
Copy Markdown
Contributor Author

Yup, and also any feedback @dessalines may have.

@pipe01 pipe01 marked this pull request as ready for review June 8, 2023 16:58
@pipe01 pipe01 requested a review from dessalines as a code owner June 8, 2023 16:58
Comment thread app/src/main/java/com/jerboa/ui/components/person/PersonProfile.kt
Comment thread app/src/main/java/com/jerboa/ui/components/common/ImageViewerDialog.kt Outdated
Comment thread app/src/main/java/com/jerboa/ui/components/common/ImageViewerDialog.kt Outdated
@pipe01

pipe01 commented Jun 8, 2023

Copy link
Copy Markdown
Contributor Author

I'm gonna try to add download notifications, and then this can be merged if there are no further issues.

@pipe01

pipe01 commented Jun 8, 2023

Copy link
Copy Markdown
Contributor Author

Nevermind, it's a big PITA, I'll do it later. It seems like the CI is having some trouble again though.

@pipe01 pipe01 requested a review from twizmwazin as a code owner June 8, 2023 20:19

@twizmwazin twizmwazin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it out and seems to work well. It doesn't appear to work for images embedded in comments yet.

@dessalines dessalines enabled auto-merge (squash) June 9, 2023 00:09
@dessalines dessalines merged commit b1b83bc into LemmyNet:main Jun 9, 2023
@shombando

Copy link
Copy Markdown
Contributor

@pipe01 thanks for all your great functionality that got merged to 0.33-alpha, the experience is improving in subtle but important ways!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow images in posts to be expanded and zoomed

5 participants