Small Accesibility Tweaks#674
Merged
twizmwazin merged 3 commits intoJun 16, 2023
Merged
Conversation
scottmmjackson
commented
Jun 15, 2023
| @@ -289,4 +289,8 @@ | |||
| <string name="topAppBar_back">Back</string> | |||
| <string name="utils_login_first">Login first</string> | |||
| <string name="voteToggle">Toggle vote</string> | |||
Contributor
Author
There was a problem hiding this comment.
Didn't drop this because I'm not sure of the implications since it's been translated a bunch
Collaborator
There was a problem hiding this comment.
If they aren't used, they should be deleted including the translations imo. Would need a code owner to make the final verdict.
Contributor
There was a problem hiding this comment.
If its unused and not expected to be used again we should remove it, but it doesn't have to be in this PR necessarily.
Contributor
Author
There was a problem hiding this comment.
- Drop
voteToggleunused string resource
twizmwazin
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #616