#602 Change post button to be more obvious#691
Merged
Conversation
twizmwazin
suggested changes
Jun 16, 2023
twizmwazin
left a comment
Contributor
There was a problem hiding this comment.
Your change looks great. Can you fix the commit history?
e705b43 to
d05bd81
Compare
Contributor
|
Run |
d05bd81 to
6d9345a
Compare
dessalines
reviewed
Jun 16, 2023
| contentDescription = stringResource(R.string.form_submit), | ||
| ) | ||
| // Todo add are you sure cancel dialog+ | ||
| if (formValid && !loading) { |
Member
There was a problem hiding this comment.
Loading was already checked above.
| // Todo add are you sure cancel dialog+ | ||
| if (formValid && !loading) { | ||
| Icon( | ||
| Icons.Filled.Send, |
Member
There was a problem hiding this comment.
Would be much easier to do icon = if (formValid) { ...
Contributor
Author
There was a problem hiding this comment.
Yep, that's much cleaner
dessalines
approved these changes
Jun 19, 2023
dessalines
left a comment
Member
There was a problem hiding this comment.
LGTM. I'll handle the merge conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #602 This changes the submit icon from
addtosubmitand adds a preview for the post header.