More Themes (Dark + Light)#750
Conversation
In that case, we should just find the correct Material3 theme variable that works best, for both. I'd rather not add custom theme hacks, or additional settings on top of M3, but just use the existing variables, to look good with all themes. |
dessalines
left a comment
There was a problem hiding this comment.
Thanks for these, they all look really good.
| enum class ThemeColor { | ||
| Dynamic, | ||
| Beach, | ||
| Blue, |
There was a problem hiding this comment.
Needs a merge from main, and you'll see that this enum has i18n strings now.
There was a problem hiding this comment.
Could you add i18n strings to this, just liken ThemeMode has above it?
There was a problem hiding this comment.
Okay, I've modified them to use i18n strings and added the English translations in the strings.xml file
Modified ThemeColor to use i18n strings, and added translations for English in app/src/main/res/values/strings.xml
…nto more-themes
Created a "Grey" option for Theme Color. Modified colors for both Dark and Light Theme.
Created a "Purple" option for Theme Color. Modified colors for both Dark and Light Theme.
Created a "Woodland" option for Theme Color. Modified colors for both Dark and Light Theme.
Created a "Beach" option for Theme Color. Modified colors for both Dark and Light Theme.
Created a "Crimson" option for Theme Color. Modified colors for both Dark and Light Theme.
The one thing that probably still needs a change is the fact that the Dialogs and the NavBar both use the .surface color, so in order to get the NavBar to be the same color as the background, the Dialogs must also be this color and can't be given a slight accent to separate it from the background. Example:
Two solutions I can think of:
I think it might also be smart to separate the .primary, .secondary, and .tertiary color as their own user settings, so that themes don't have to be made for each possible primary color that a user might want to use. For instance, for the Grey (Dark) theme, I've made the .primary color just ever so slightly Blue to separate it more from the other UI on the home feed (since most of the other text is already grey). However, it would be nice if a user could change that to be green, pink, purple, etc etc (custom color picker, not hard coded colors) while still being able to use my general color scheme.
I can try my hand at any of the above solutions, just let me know what direction if any you'd like to go with it.
Also, question. I wasn't able to see where the URL color in comments is found in the code, since I'd like to be able to theme that too (and ultimately should probably have its own user setting override as well). Right now it seems to be hardcoded as this green color:
Let me know if you'd like me to make any changes. I plan on making more themes.