Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add rough rudimentary CONTRIBUTING.md#753

Merged
dessalines merged 10 commits into
LemmyNet:mainfrom
MV-GH:doc/contrib
Jun 19, 2023
Merged

Add rough rudimentary CONTRIBUTING.md#753
dessalines merged 10 commits into
LemmyNet:mainfrom
MV-GH:doc/contrib

Conversation

@MV-GH

@MV-GH MV-GH commented Jun 19, 2023

Copy link
Copy Markdown
Collaborator

Add rough rudimentary CONTRIBUTING.md

Please if you have any suggestions comment here

Comment thread CONTRIBUTING.md Outdated
@ZJouba

ZJouba commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

Someone mentioned Jetpack Compose on Matrix, maybe add a little something about that. Also, maybe a link to preferred Kotlin coding standards?

@MV-GH

MV-GH commented Jun 19, 2023

Copy link
Copy Markdown
Collaborator Author

Someone mentioned Jetpack Compose on Matrix, maybe add a little something about that. Also, maybe a link to preferred Kotlin coding standards?

Jetpack Compose is already mentioned in the README not sure what else to say about it

and I cant find the kotlin coding standards
https://github.com/jeremymailen/kotlinter-gradle their github pages is down for me

@ZJouba

ZJouba commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

Could link to the ktlint rules https://pinterest.github.io/ktlint/0.49.1/rules/code-styles/?

@MV-GH

MV-GH commented Jun 19, 2023

Copy link
Copy Markdown
Collaborator Author

Thx for finding that for me, I link to https://pinterest.github.io/ktlint/0.49.1/rules/standard/ instead since we just use the default rules.

@ZJouba

ZJouba commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

Oh, maybe something about branch name standard as well?

@MV-GH

MV-GH commented Jun 19, 2023

Copy link
Copy Markdown
Collaborator Author

There is a standard for branch names?

@dessalines dessalines left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, content all looks great. This doc will evolve over time anyway.

Just get rid of those hard line-wraps and I'll merge.

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md
@dessalines

Copy link
Copy Markdown
Member

Haha no standard for branch names or commit content, I'm not a stickler for that stuff. The code is what matters.

@dessalines dessalines left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thx!

@dessalines dessalines merged commit a51d83f into LemmyNet:main Jun 19, 2023
@MV-GH MV-GH deleted the doc/contrib branch July 5, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants