Codestin Search App

nahwneeth · 2023-06-22T13:56:10Z

Since PR #765 was too big, splitting it up into multiple PR to make it easier to review.

Scoped view models

All the view models that were declared in the activity are now scoped to the routes in which they are used. View models used by most of the routes (like SiteViewModel, AccountViewModel & AccountSettingsViewModel) are left untouched.
This prevents sharing view models that lead to stale data & reloading the data when navigating back.
Making the LaunchedEffect run only once per route. This helps ensure that the content isn't reset with new data when moving back from one route to another. Things like scroll position & filters are also retained.
Using extension function on navController to navigate in a type safe manner.

Closes #704
Closes #402
Closes #774
Closes #835

The following is the existing design where the view models reside in the MainActivity and are passed to all the activities:

The following is the design implemented by the PR:

The channel is also a ViewModel that is scoped to the NavHost's nav graph which has route = Route.Graph.ROOT. This is created on the fly whenever you see something like transferPostEditDepsViaRoot = navController.rootChannel<PostEditDeps>().
Instead of initializing a global viewmodel and then navigating to it's activity. We store the dependencies in the global channel and then initialize the view model in it's respective activity.
On success the updated data is put to the parent's back stack entry with a specific key (PostEditReturn.POST_VIEW) and then navigate back. On navigating back, the parent will recompose and we check if a value has been set in PostEditReturn.POST_VEW and update the post accordingly.

Other Notes:

I've provided extensions to navigate to each activity. For eg. to navigate to PostEditActivity on has to call navController.toPostEdit(Channel<PostView>, PostView). This way it's a compile time error to forget providing the dependencies necessary to initialize an activity.
These deps are converted to JSON and rememberSaved in the respective route (when navController.takeDepsFromRoot<PostView>() is called). The updated data on the back stack entry's SavedStateHandle is also in JSON. Both survive process death.
To reuse code, I've introduced abstractions like InitializeRoute and ConsumeResult which are self-explanatory.

nahwneeth · 2023-06-22T14:05:52Z

@marcellogalhardo

I've updated the code to survive process death. Would appreciate if you also reviewed this. I've taken your previous feedback into consideration and creating view models on the fly, using extension functions for navigation and moved the initialized variable into the view model. The dependencies are converted to Json and being rememberSaved.

For people willing to test this branch (& for my future ref):

Go to any view/screen. Click on posts & profiles & communities any number of time in a sequence.
Click on home button / swipe home.
To kill the process do:
./adb shell am kill com.jerboa.debug
Open the app again from recents and the app should continue from where you left off.

dessalines · 2023-06-22T14:16:22Z

It might be a while till I can go over bigger refactors like this.

twizmwazin

Would love to get this merged once rebased

nahwneeth · 2023-06-26T04:10:57Z

Note regarding changes made while resolving merge conflicts:

The user preferred sort & listing defaults were housed in HomeViewModel (PR Fix default sort and listing type to read from db #854). This has been moved to SiteViewModel. Reason: The CommunityActivity depended on HomeViewModel for the defaults which hinders scoping. Since, both already depended on SiteViewModel it made more sense to keep them there. Also, changing the filters in HomeActivity doesn't overwrite the user defaults. Would appreciate if @beatgammit reviewed these changes and pointed out if I missed out or overwrote any fixes.
The PostCreate & PostEdit were consolidated (PR Consolidate composables for CreatePost and PostEdit #860). I've tested the post edit and create functionality after rebasing and they seem to be working. Would appreciate if @sockenklaus reviewed these changes & gave a thumbs up.

sockenklaus · 2023-06-26T05:34:21Z

Would appreciate if @sockenklaus reviewed these changes gave a thumbs up.

I'll gladly do and give it a look tonight.

…r default sort and listing type.

nahwneeth · 2023-06-26T07:17:46Z

I've opened a new issue for the filters #886. For now, I've pushed a commit to ensure that the filters (in home & community activity) are read form the account variable. Ig we can continue with merging this PR and take up the filters thing separately. Any other issues with this branch, do let me know.

sockenklaus

I only reviewed the files regarding post creation and editing because I honestly can't wrap around my head about that amount of abstraction you added without investing a serious amount of time which I just don't have atm. (Hence my rather small PRs)
What I reviewed looked correct though and post creation and editing acted as expected.

nahwneeth · 2023-06-26T14:22:13Z

What I reviewed looked correct though and post creation and editing acted as expected.

Thanks a lot for taking the time! Will make the changes you requested.

I think that's the hard part, reviewing changes. I'll try to document these changes better.

sockenklaus · 2023-06-26T17:51:19Z

I think that's the hard part, reviewing changes. I'll try to document these changes better.

Thank you for further describing the changes you've made. I really appreciate your effort to make these changes as understandable as possible. 🙂

MV-GH · 2023-09-01T04:19:28Z

I have question regarding initializeRoute, why did you take this approach over just having the necessary fields passed to the constructor of the ViewModel. Passing it in the constructor is much more typesafe as we now don't have to set each field as nullable that we have to check constantly

nahwneeth · 2023-09-01T04:45:08Z

I was trying to keep the changes small in this PR since it was getting harder to review. Other than the `initialized` field the view models don't have any other changes. Constructor initialization of view models is safer and we should try to do that.

…

On Fri, 1 Sept, 2023, 9:49 am Maarten Vercruysse, ***@***.***> wrote: I have question regarding initializeRoute, why did you take this approach over just having the necessary fields passed to the constructor of the ViewModel. Passing it in the constructor is much more typesafe as we now don't have to set each field as nullable that we have to check constantly — Reply to this email directly, view it on GitHub <#817 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANLBAUM4L76V4ATIW32RZGDXYFO5XANCNFSM6AAAAAAZQIAPA4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

MV-GH · 2023-09-01T05:22:33Z

Thanks for your quick response, I'll make a issue for that and work on refactoring that

MV-GH · 2023-09-01T17:26:20Z

I do have another question,

For communityViewmodel you did this

val communityViewModel: CommunityViewModel = viewModel(
   remember(it) { navController.getBackStackEntry(Route.Graph.COMMUNITY) },
)

I am not sure what this does or why it exists?

Why can it not be embedded in CommunityAcitivity?

nahwneeth · 2023-09-01T17:37:26Z

navController.getBackStackEntry(Route.Graph.COMMUNITY) This scopes the view model to the route with name Route.Graph.COMMUNITY The community activity and community sidebar need to utilise the same view model. I've made both these activities as subroutes of Route.Graph.COMMUNITY. So when creating a view model we don't scope it to the route but instead to it's parent. When you navigate to the sidebar, it ends up using the view model scoped to the parent. So both community activity and community sidebar activity aren't embedded.

…

On Fri, 1 Sept, 2023, 10:56 pm Maarten Vercruysse, ***@***.***> wrote: I do have another question, For communityViewmodel you did this val communityViewModel: CommunityViewModel = viewModel( remember(it) { navController.getBackStackEntry(Route.Graph.COMMUNITY) }, ) I am not sure what this does or why it exists? Why can it not be embedded in CommunityAcitivity? — Reply to this email directly, view it on GitHub <#817 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANLBAUJ222UYPDL2IPSQXFDXYILERANCNFSM6AAAAAAZQIAPA4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

MV-GH · 2023-09-01T18:00:13Z

Hmm I see but I am thinking of simplifying this by just passing the CommunityView into Sidebar using the addReturn. Would a separate community_graph still be needed then?

nahwneeth · 2023-09-01T18:07:56Z

Interesting. Give it a try. Make sure to put the addReturn lines within the NavController.toCommunitySidebar() extension method. It should work and the dependency is also explicit ig.

…

On Fri, 1 Sept, 2023, 11:30 pm Maarten Vercruysse, ***@***.***> wrote: Hmm I see but I am thinking of simplifying this by just passing the CommunityView into Sidebar using the addReturn. Would a separate community_graph still be needed then? — Reply to this email directly, view it on GitHub <#817 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANLBAUM5S4NOAFCKKEAZPHDXYIPDPANCNFSM6AAAAAAZQIAPA4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

MV-GH · 2023-09-01T18:39:26Z

Alright got it working, had to make a reverse addReturn/consumeReturn

nahwneeth requested review from dessalines and twizmwazin as code owners June 22, 2023 13:56

nahwneeth mentioned this pull request Jun 23, 2023

Navigation Enhancements x2 #765

Closed

twizmwazin approved these changes Jun 25, 2023

View reviewed changes

twizmwazin mentioned this pull request Jun 26, 2023

Parent comment navigation buttons block bottom of comments #883

Closed

nahwneeth force-pushed the scoped-view-models branch from 54592b3 to b614511 Compare June 26, 2023 03:18

nahwneeth added 2 commits June 26, 2023 08:56

Scoped View Models that also survive process death.

4af09ba

Fix rebase

4560d8e

nahwneeth marked this pull request as draft June 26, 2023 03:30

Fix rebase

d99a123

nahwneeth force-pushed the scoped-view-models branch from b614511 to d99a123 Compare June 26, 2023 03:45

nahwneeth marked this pull request as ready for review June 26, 2023 03:45

Fix rebase

f568976

nahwneeth mentioned this pull request Jun 26, 2023

Default Listing and Sort types not respected #857

Closed

Fix sort & listing type async

5c7127a

twizmwazin suggested changes Jun 26, 2023

View reviewed changes

nahwneeth added 2 commits June 26, 2023 10:43

Added requested changes.

f9f3cb6

Move homeViewModel up

0059488

twizmwazin approved these changes Jun 26, 2023

View reviewed changes

Avoid fetching site on every recompose. Use local account settings fo…

6625f92

…r default sort and listing type.

sockenklaus reviewed Jun 26, 2023

View reviewed changes

Comment thread app/src/main/java/com/jerboa/ui/components/post/create/CreatePostActivity.kt

Comment thread app/src/main/java/com/jerboa/ui/components/post/edit/PostEditActivity.kt

Comment thread app/src/main/java/com/jerboa/ui/components/post/edit/PostEditActivity.kt

twizmwazin mentioned this pull request Jun 26, 2023

(0.0.36) Login only gets represented in app after reopening #888

Closed

Merge branch 'main' into scoped-view-models

9daeea6

twizmwazin merged commit 0557d7f into LemmyNet:main Jun 26, 2023

scme0 mentioned this pull request Jun 27, 2023

Default sort and listing type cannot be overridden #887

Closed

MV-GH mentioned this pull request Jun 27, 2023

Filters are different in server & local database. #886

Closed

twizmwazin mentioned this pull request Jun 28, 2023

Add swiping between posts in PostActivity #872

Closed

MV-GH mentioned this pull request Jun 30, 2023

App v0.0.37 crashes when hitting "Back" in a post #927

Closed

MV-GH mentioned this pull request Sep 1, 2023

Refactor initializable to use constructor instead in viewmodels where possible #1208

Closed

3 tasks

Uh oh!

Conversation

nahwneeth commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Scoped view models

Uh oh!

nahwneeth commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dessalines commented Jun 22, 2023

Uh oh!

twizmwazin left a comment

Choose a reason for hiding this comment

Uh oh!

nahwneeth commented Jun 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sockenklaus commented Jun 26, 2023

Uh oh!

nahwneeth commented Jun 26, 2023

Uh oh!

sockenklaus left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nahwneeth commented Jun 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sockenklaus commented Jun 26, 2023

Uh oh!

MV-GH commented Sep 1, 2023

Uh oh!

nahwneeth commented Sep 1, 2023 via email

Uh oh!

MV-GH commented Sep 1, 2023

Uh oh!

MV-GH commented Sep 1, 2023

Uh oh!

nahwneeth commented Sep 1, 2023 via email

Uh oh!

MV-GH commented Sep 1, 2023

Uh oh!

nahwneeth commented Sep 1, 2023 via email

Uh oh!

MV-GH commented Sep 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nahwneeth commented Jun 22, 2023 •

edited

Loading

nahwneeth commented Jun 22, 2023 •

edited

Loading

nahwneeth commented Jun 26, 2023 •

edited

Loading

sockenklaus left a comment •

edited

Loading

nahwneeth commented Jun 26, 2023 •

edited

Loading