Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Show the users' federated name in drawer.#937

Merged
dessalines merged 8 commits into
LemmyNet:mainfrom
camporter:show_federated_name_in_drawer
Jul 3, 2023
Merged

Show the users' federated name in drawer.#937
dessalines merged 8 commits into
LemmyNet:mainfrom
camporter:show_federated_name_in_drawer

Conversation

@camporter

Copy link
Copy Markdown
Contributor

This lets users know which instance they are on more easily.

Also change the 'Switch to' name/server format to match the federated name format using @.

federated_name_in_drawer

@MV-GH

MV-GH commented Jul 1, 2023

Copy link
Copy Markdown
Collaborator

What happens if the name is way too long? Does it completely clip it out? If so you should probably change the text clipping to do the ellipsis thing.

@camporter

Copy link
Copy Markdown
Contributor Author

The federated name was previously given one line and clip. Gave it two and ellipsis and it seems like that should be plenty 🙂

The existing PersonName behavior I've left alone.

Both were able to knock the expandable arrow out of the row, so set weights.

Comment thread app/src/main/java/com/jerboa/ui/components/home/Home.kt Outdated
@MV-GH

MV-GH commented Jul 2, 2023

Copy link
Copy Markdown
Collaborator

Greek string file should be updated now too

@dessalines dessalines left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dessalines dessalines merged commit e51ab9f into LemmyNet:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants